Skip to content

Commit f3a4bc8

Browse files
smailletsmaillet
authored
Test Updates (#259)
* Removed custom `SkipTestMethodAttribute` * Framework has built-in `Ignore` attribute for same purpose * Removed extended Value cache support as it is no longer used. * Minor doc comment corrections/clarifications Co-authored-by: smaillet <25911635+smaillet@users.noreply.github.com>
1 parent b9c2bdf commit f3a4bc8

13 files changed

Lines changed: 216 additions & 175 deletions

‎src/Interop/InteropTests/ABI/libllvm-c/AttributeBindingsTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
using Ubiquity.NET.Extensions;
1616
using Ubiquity.NET.InteropHelpers;
1717
using Ubiquity.NET.Llvm.Interop.ABI.StringMarshaling;
18-
using Ubiquity.NET.Llvm.Interop.UT;
1918

2019
using static Ubiquity.NET.Llvm.Interop.ABI.libllvm_c.AttributeBindings;
2120
using static Ubiquity.NET.Llvm.Interop.ABI.llvm_c.Core;
@@ -106,7 +105,8 @@ public void LibLLVMIsConstantRangeAttributeTest( )
106105
Assert.IsFalse( LibLLVMIsConstantRangeAttribute( enumAttrib ) );
107106
}
108107

109-
[SkipTestMethod]
108+
[TestMethod]
109+
[Ignore("Constant Range List Creation is unknown - test currently ignored")]
110110
public void LibLLVMIsConstantRangeListAttributeTest( )
111111
{
112112
// At present the creation of a constant range list attribute instance is

‎src/Interop/InteropTests/ABI/libllvm-c/IRBindingsTests.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,13 @@
66

77
using Microsoft.VisualStudio.TestTools.UnitTesting;
88

9-
using Ubiquity.NET.Llvm.Interop.UT;
10-
119
namespace Ubiquity.NET.Llvm.Interop.ABI.libllvm_c.UT
1210
{
1311
[TestClass]
1412
public class IRBindingsTests
1513
{
16-
[SkipTestMethod]
14+
[TestMethod]
15+
[Ignore("Not yet implemented")]
1716
public void LibLLVMHasUnwindDestTest( )
1817
{
1918
// As of this writing, the only implemented instructions that might contain an unwind dest are a CleanupReturn and

‎src/Interop/InteropTests/ABI/libllvm-c/MetadataBindingsTests.cs‎

Lines changed: 58 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -8,182 +8,209 @@
88

99
using Microsoft.VisualStudio.TestTools.UnitTesting;
1010

11-
using Ubiquity.NET.Llvm.Interop.UT;
12-
1311
namespace Ubiquity.NET.Llvm.Interop.ABI.libllvm_c.UT
1412
{
1513
[TestClass]
1614
public class MetadataBindingsTests
1715
{
18-
[SkipTestMethod]
16+
[TestMethod]
17+
[Ignore("Not yet implemented")]
1918
public void LibLLVMDIBasicTypeGetEncodingTest( )
2019
{
2120
throw new NotImplementedException();
2221
}
2322

24-
[SkipTestMethod]
23+
[TestMethod]
24+
[Ignore("Not yet implemented")]
2525
public void LibLLVMGetNodeContextTest( )
2626
{
2727
throw new NotImplementedException();
2828
}
2929

30-
[SkipTestMethod]
30+
[TestMethod]
31+
[Ignore("Not yet implemented")]
3132
public void LibLLVMDiCompileUnitGetEmissionKindTest( )
3233
{
3334
throw new NotImplementedException();
3435
}
3536

36-
[SkipTestMethod]
37+
[TestMethod]
38+
[Ignore("Not yet implemented")]
3739
public void LibLLVMDIBuilderCreateTempFunctionFwdDeclTest( )
3840
{
3941
throw new NotImplementedException();
4042
}
4143

42-
[SkipTestMethod]
44+
[TestMethod]
45+
[Ignore("Not yet implemented")]
4346
public void LibLLVMDIBuilderFinalizeSubProgramTest( )
4447
{
4548
throw new NotImplementedException();
4649
}
4750

48-
[SkipTestMethod]
51+
[TestMethod]
52+
[Ignore("Not yet implemented")]
4953
public void LibLLVMDIDescriptorGetTagTest( )
5054
{
5155
throw new NotImplementedException();
5256
}
5357

54-
[SkipTestMethod]
58+
[TestMethod]
59+
[Ignore("Not yet implemented")]
5560
public void LibLLVMDILocationGetInlinedAtScopeTest( )
5661
{
5762
throw new NotImplementedException();
5863
}
5964

60-
[SkipTestMethod]
65+
[TestMethod]
66+
[Ignore("Not yet implemented")]
6167
public void LibLLVMMetadataAsStringTest( )
6268
{
6369
throw new NotImplementedException();
6470
}
6571

66-
[SkipTestMethod]
72+
[TestMethod]
73+
[Ignore("Not yet implemented")]
6774
public void LibLLVMMDNodeGetNumOperandsTest( )
6875
{
6976
throw new NotImplementedException();
7077
}
7178

72-
[SkipTestMethod]
79+
[TestMethod]
80+
[Ignore("Not yet implemented")]
7381
public void LibLLVMMDNodeGetOperandTest( )
7482
{
7583
throw new NotImplementedException();
7684
}
7785

78-
[SkipTestMethod]
86+
[TestMethod]
87+
[Ignore("Not yet implemented")]
7988
public void LibLLVMMDNodeReplaceOperandTest( )
8089
{
8190
throw new NotImplementedException();
8291
}
8392

84-
[SkipTestMethod]
93+
[TestMethod]
94+
[Ignore("Not yet implemented")]
8595
public void LibLLVMGetOperandNodeTest( )
8696
{
8797
throw new NotImplementedException();
8898
}
8999

90-
[SkipTestMethod]
100+
[TestMethod]
101+
[Ignore("Not yet implemented")]
91102
public void LibLLVMNamedMetadataGetParentModuleTest( )
92103
{
93104
throw new NotImplementedException();
94105
}
95106

96-
[SkipTestMethod]
107+
[TestMethod]
108+
[Ignore("Not yet implemented")]
97109
public void LibLLVMNamedMetadataEraseFromParentTest( )
98110
{
99111
throw new NotImplementedException();
100112
}
101113

102-
[SkipTestMethod]
114+
[TestMethod]
115+
[Ignore("Not yet implemented")]
103116
public void LibLLVMGetMetadataIDTest( )
104117
{
105118
throw new NotImplementedException();
106119
}
107120

108-
[SkipTestMethod]
121+
[TestMethod]
122+
[Ignore("Not yet implemented")]
109123
public void LibLLVMNamedMDNodeGetNumOperandsTest( )
110124
{
111125
throw new NotImplementedException();
112126
}
113127

114-
[SkipTestMethod]
128+
[TestMethod]
129+
[Ignore("Not yet implemented")]
115130
public void LibLLVMNamedMDNodeGetOperandTest( )
116131
{
117132
throw new NotImplementedException();
118133
}
119134

120-
[SkipTestMethod]
135+
[TestMethod]
136+
[Ignore("Not yet implemented")]
121137
public void LibLLVMNamedMDNodeSetOperandTest( )
122138
{
123139
throw new NotImplementedException();
124140
}
125141

126-
[SkipTestMethod]
142+
[TestMethod]
143+
[Ignore("Not yet implemented")]
127144
public void LibLLVMNamedMDNodeAddOperandTest( )
128145
{
129146
throw new NotImplementedException();
130147
}
131148

132-
[SkipTestMethod]
149+
[TestMethod]
150+
[Ignore("Not yet implemented")]
133151
public void LibLLVMNamedMDNodeClearOperandsTest( )
134152
{
135153
throw new NotImplementedException();
136154
}
137155

138-
[SkipTestMethod]
156+
[TestMethod]
157+
[Ignore("Not yet implemented")]
139158
public void LibLLVMConstantAsMetadataTest( )
140159
{
141160
throw new NotImplementedException();
142161
}
143162

144-
[SkipTestMethod]
163+
[TestMethod]
164+
[Ignore("Not yet implemented")]
145165
public void LibLLVMGetMDStringTextTest( )
146166
{
147167
throw new NotImplementedException();
148168
}
149169

150-
[SkipTestMethod]
170+
[TestMethod]
171+
[Ignore("Not yet implemented")]
151172
public void LibLLVMAddNamedMetadataOperand2Test( )
152173
{
153174
throw new NotImplementedException();
154175
}
155176

156-
[SkipTestMethod]
177+
[TestMethod]
178+
[Ignore("Not yet implemented")]
157179
public void LibLLVMSetMetadata2Test( )
158180
{
159181
throw new NotImplementedException();
160182
}
161183

162-
[SkipTestMethod]
184+
[TestMethod]
185+
[Ignore("Not yet implemented")]
163186
public void LibLLVMIsTemporaryTest( )
164187
{
165188
throw new NotImplementedException();
166189
}
167190

168-
[SkipTestMethod]
191+
[TestMethod]
192+
[Ignore("Not yet implemented")]
169193
public void LibLLVMIsResolvedTest( )
170194
{
171195
throw new NotImplementedException();
172196
}
173197

174-
[SkipTestMethod]
198+
[TestMethod]
199+
[Ignore("Not yet implemented")]
175200
public void LibLLVMIsUniquedTest( )
176201
{
177202
throw new NotImplementedException();
178203
}
179204

180-
[SkipTestMethod]
205+
[TestMethod]
206+
[Ignore("Not yet implemented")]
181207
public void LibLLVMIsDistinctTest( )
182208
{
183209
throw new NotImplementedException();
184210
}
185211

186-
[SkipTestMethod]
212+
[TestMethod]
213+
[Ignore("Not yet implemented")]
187214
public void LibLLVMDISubRangeGetLowerBoundsTest( )
188215
{
189216
throw new NotImplementedException();

0 commit comments

Comments
 (0)