Stabilyze tests

src/bin/mapvas/main.rs

@@ -56,7 +56,7 @@ fn main() -> eframe::Result {
       let config = Config::new();
       init_style_config(config.vector_style_file.as_deref());
 
-      let (map, remote, data_holder) = Map::new(cc.egui_ctx.clone());
+      let (map, remote, data_holder) = Map::new(cc.egui_ctx.clone(), config.clone());
       spawn_remote_runner(runtime, remote.clone());
       Ok(Box::new(MapApp::new(
         map,

src/headless.rs

@@ -61,7 +61,7 @@ impl HeadlessRenderer {
   #[must_use]
   pub fn render(&self, events: &[MapEvent], width: u32, height: u32) -> image::RgbaImage {
     let ctx = egui::Context::default();
-    let (mut map, remote, data_holder) = Map::new(ctx);
+    let (mut map, remote, data_holder) = Map::new(ctx, self.config.clone());
     map.set_headless();
 
     for event in events {

src/map/mapvas_egui.rs

@@ -54,9 +54,10 @@ pub struct Map {
 
 impl Map {
   #[must_use]
-  pub fn new(ctx: egui::Context) -> (Self, Remote, Rc<dyn MapLayerHolder>) {
-    let cfg = crate::config::Config::new();
-
+  pub fn new(
+    ctx: egui::Context,
+    cfg: crate::config::Config,
+  ) -> (Self, Remote, Rc<dyn MapLayerHolder>) {
     let tile_layer = layer::TileLayer::from_config(ctx.clone(), &cfg);
     let shape_info = std::sync::Arc::new(std::sync::RwLock::new(std::collections::HashMap::new()));
     let shape_layer = layer::ShapeLayer::new(cfg.clone(), ctx.clone(), shape_info.clone());

src/map/mapvas_egui/helpers.rs

@@ -35,27 +35,36 @@ pub(crate) fn fit_to_screen(transform: &mut Transform, rect: &Rect) {
   transform.zoom = transform.zoom.clamp(MIN_ZOOM, MAX_ZOOM);
 
   let inv = transform.invert();
-  let PixelCoordinate { x: _, y } = inv.apply(PixelPosition { x: 0., y: 0. });
-  if y < 0. {
-    transform.translate(
-      PixelPosition {
-        x: 0.,
-        y: y.min(0.),
-      } * transform.zoom,
-    );
-  }
+  let world_h_screen = CANVAS_SIZE * transform.zoom;
+  let view_h = rect.height();
+  let top_y = inv.apply(PixelPosition { x: 0., y: 0. }).y;
 
-  let PixelCoordinate { x: _, y } = inv.apply(PixelPosition {
-    x: rect.max.x,
-    y: rect.max.y,
-  });
-  if y > CANVAS_SIZE {
-    transform.translate(
-      PixelPosition {
+  if view_h >= world_h_screen {
+    // Viewport is taller than the world — center the world vertically. Without this,
+    // top-anchor and bottom-anchor clamps below would both fire and oscillate.
+    let desired_top_y = -(view_h - world_h_screen) / (2. * transform.zoom);
+    let shift = (top_y - desired_top_y) * transform.zoom;
+    if shift.abs() > 0.01 {
+      transform.translate(PixelPosition { x: 0., y: shift });
+    }
+  } else if top_y < 0. {
+    transform.translate(PixelPosition {
+      x: 0.,
+      y: top_y * transform.zoom,
+    });
+  } else {
+    let bottom_y = inv
+      .apply(PixelPosition {
+        x: rect.max.x,
+        y: rect.max.y,
+      })
+      .y;
+    if bottom_y > CANVAS_SIZE {
+      transform.translate(PixelPosition {
         x: 0.,
-        y: (y - CANVAS_SIZE).max(0.),
-      } * transform.zoom,
-    );
+        y: (bottom_y - CANVAS_SIZE) * transform.zoom,
+      });
+    }
   }
 
   // Wrap the x-translation so the viewport stays within one canonical world.

tests/grid_snapshot_tests.rs

@@ -13,7 +13,7 @@ use std::io::Cursor;
 fn create_test_app_with_geojson_grid_mode(geojson_content: String) -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   // Parse the GeoJSON content and inject it as a map event
@@ -35,7 +35,7 @@ fn create_test_app_with_geojson_grid_mode(geojson_content: String) -> MapApp {
 fn create_test_app_grid_mode() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
   MapApp::new(map, remote, data_holder, config, None)
 }
@@ -221,17 +221,26 @@ async fn grid_mode_ui_workflow() {
     app,
   );
 
-  // Step 1: Initial state with loaded data
+  // Setup: switch to grid-only display via the settings UI so subsequent
+  // snapshots don't depend on real tile loads.
+  harness.run();
+  harness.get_by_label("Tile Layer").click();
+  harness.run();
+  harness.get_by_label("Grid Only").click();
   harness.run();
+  harness.get_by_label("Tile Layer").click();
+  harness.run();
+
+  // Step 1: Initial state with loaded data
   harness.snapshot("workflow_initial_with_data");
 
-  // Step 2: Open tile layer settings
+  // Step 2: Open tile layer settings (Grid Only is already selected from setup)
   let tile_layer = harness.get_by_label("Tile Layer");
   tile_layer.click();
   harness.run();
   harness.snapshot("workflow_settings_opened");
 
-  // Step 3: Switch directly to grid mode (avoiding tile dependencies)
+  // Step 3: Re-click Grid Only to verify the radio still works
   let grid_only_button = harness.get_by_label("Grid Only");
   grid_only_button.click();
   harness.run();

tests/highlight_snapshot_tests.rs

@@ -13,7 +13,7 @@ use std::io::Cursor;
 fn create_test_app_with_geometries() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   // Use nested folders KML to have both collections and individual geometries
@@ -90,6 +90,19 @@ async fn test_individual_geometry_highlighting() {
 
   harness.run();
 
+  // Switch to grid mode so snapshots don't depend on real tile loads
+  let tile_layer = harness.get_by_label("Tile Layer");
+  tile_layer.click();
+  harness.run();
+
+  let grid_only_button = harness.get_by_label("Grid Only");
+  grid_only_button.click();
+  harness.run();
+
+  let tile_layer = harness.get_by_label("Tile Layer");
+  tile_layer.click();
+  harness.run();
+
   // Setup to reach individual geometries
   let shape_layer = harness.get_by_label("Shape Layer");
   shape_layer.click();

tests/popup_double_click_tests.rs

@@ -12,7 +12,7 @@ use std::io::Cursor;
 fn create_test_app_with_nested_kml() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   // Create nested KML content with multiple levels

tests/popup_snapshot_tests.rs

@@ -13,7 +13,7 @@ use std::io::Cursor;
 fn create_test_app_with_popup_kml() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   // Read and parse the test KML file with MultiGeometry

tests/temporal_snapshot_tests.rs

@@ -13,7 +13,7 @@ use std::io::Cursor;
 fn create_test_app_with_temporal_kml() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   // Read and parse the temporal KML file
@@ -38,7 +38,7 @@ fn create_test_app_with_temporal_kml() -> MapApp {
 fn create_test_app_with_unix_epoch_kml() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   // Read and parse the unix epoch KML file
@@ -390,7 +390,7 @@ async fn unix_epoch_temporal_filtering() {
 fn create_test_app_with_debug_range_kml() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   // Read and parse the debug range KML file (2-minute span)
@@ -415,7 +415,7 @@ fn create_test_app_with_debug_range_kml() -> MapApp {
 fn create_test_app_with_unix_epoch_no_tz_kml() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   // Read and parse the unix epoch KML file without timezone
@@ -529,7 +529,7 @@ async fn large_file_temporal_parsing() {
 
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (mut map, remote, data_holder) = Map::new(ctx);
+  let (mut map, remote, data_holder) = Map::new(ctx, config.clone());
   map.set_headless();
 
   let mut parser = KmlParser::new();

tests/ui_tests.rs

@@ -7,7 +7,7 @@ use mapvas::{config::Config, map::mapvas_egui::Map, mapvas_ui::MapApp};
 fn create_test_app() -> MapApp {
   let config = Config::default();
   let ctx = egui::Context::default();
-  let (map, remote, data_holder) = Map::new(ctx);
+  let (map, remote, data_holder) = Map::new(ctx, config.clone());
   MapApp::new(map, remote, data_holder, config, None)
 }