Open
Conversation
RestServletTest was the only consumer; its 13 scenarios are already covered end-to-end by JettyRestCallTest, SttpRestCallTest, and EndpointsIntegrationTest, which run the real RestServlet behind a real Jetty server. The one previously-unique scenario (mid-stream failure closing the servlet output stream) is ported to StreamingRestApiTestScenarios via the existing errorStream fixture, so JettyRestCallTest now verifies it against a real HTTP client. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
0f7f123 to
2586f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mockito-scala-scalatestdependency (and its transitive Mockito/ByteBuddy chain) fromrestJvmDeps.RestServletTest, the single file that used it. Its 13 scenarios were already covered end-to-end byJettyRestCallTest,SttpRestCallTest, andEndpointsIntegrationTest, which exercise the realRestServletbehind a real Jetty server — strictly higher fidelity than the mock-based variant.StreamingRestApiTestScenariosvia the pre-existingerrorStreamfixture. Uses an explicit.timeout(5.seconds)so a servlet regression that fails to close the stream fails loudly rather than hanging.QA impact
RestServletviaJettyRestCallTest— higher coverage than before."mid-stream server error propagates to client"inStreamingRestApiTestScenarios.Test plan
sbt rest/test— 128 tests pass across 11 suites.sbt rest-jetty/test— 28 tests including the new case pass.sbt compile Test/compile— clean across all modules.mockito/org.mockito— zero hits.🤖 Generated with Claude Code