fix(apollo-react): remove unnecessary conversion code

Author: david-rios-uipath

packages/apollo-react/scripts/plugin-copy-locales.ts

@@ -6,21 +6,41 @@ const __dirname = dirname(fileURLToPath(import.meta.url));
 const packageRoot = dirname(__dirname);
 
 /**
- * Convert CommonJS locale module to ESM named export format
- * From: module.exports={messages:JSON.parse("{...}")};
- * To: export const messages=JSON.parse("{...}");
+ * Copy Lingui-compiled locale catalogs from `src/**\/locales/` into `dist/`.
  *
- * The locale-registry imports `{ messages }` as a named export,
- * so we must produce a named export, not `export default`.
+ * Lingui is configured with `compileNamespace: 'es'`, so it emits ESM modules
+ * as `*.mjs` with a named export:
+ *
+ *   /\*eslint-disable*\/export const messages=JSON.parse("{...}");
+ *
+ * For `dist/` we need:
+ *   - `*.js`  — ESM consumers (identical contents to the `.mjs`, just renamed
+ *               so rslib's `.mjs → .js` import rewriting in compiled output
+ *               resolves correctly).
+ *   - `*.cjs` — CommonJS consumers, synthesized by wrapping the RHS of the
+ *               single `export const messages=…;` statement in
+ *               `module.exports = { messages: … };`.
+ *   - `*.json` — copied verbatim for runtime catalog loaders.
+ *
+ * The CJS synthesis is intentionally tied to the exact shape Lingui emits.
+ * If Lingui ever changes its ESM output format, we fail loudly (throw) so
+ * the breakage surfaces here rather than as a silent link-time error in a
+ * downstream package (see `locale-registry.ts`, which imports
+ * `{ messages }` as a named export).
  */
-function convertToESM(content: string): string {
-  const prefix = 'module.exports={messages:';
-  const start = content.indexOf(prefix);
-  if (start !== -1) {
-    const value = content.slice(start + prefix.length, -2); // strip trailing "};"
-    return `/*eslint-disable*/export const messages=${value};`;
+const ESM_PREFIX = '/*eslint-disable*/export const messages=';
+
+function esmToCjs(esmContent: string, srcFile: string): string {
+  const trimmed = esmContent.trimEnd();
+  if (!trimmed.startsWith(ESM_PREFIX) || !trimmed.endsWith(';')) {
+    throw new Error(
+      `plugin-copy-locales: unexpected Lingui ESM output in ${srcFile}.\n` +
+        `Expected a file starting with '${ESM_PREFIX}' and ending with ';'.\n` +
+        `Got:\n${trimmed.slice(0, 200)}...`
+    );
   }
-  return content.replace(/module\.exports\s*=\s*/, 'export default ');
+  const rhs = trimmed.slice(ESM_PREFIX.length, -1); // strip prefix + trailing `;`
+  return `/*eslint-disable*/module.exports={messages:${rhs}};`;
 }
 
 export function pluginCopyLocales() {
@@ -41,53 +61,26 @@ export function pluginCopyLocales() {
               const distLocales = join(distDir, relativePath);
 
               if (existsSync(srcLocales)) {
-                // Ensure dist directory exists
                 mkdirSync(distLocales, { recursive: true });
 
-                // Process each locale file
-                const files = readdirSync(srcLocales);
-                for (const file of files) {
-                  if (file.endsWith('.js')) {
-                    const srcFile = join(srcLocales, file);
-                    const content = readFileSync(srcFile, 'utf-8');
-
-                    // Write .cjs (CommonJS format)
-                    const cjsFile = join(distLocales, file.replace('.js', '.cjs'));
-                    writeFileSync(cjsFile, content, 'utf-8');
+                for (const file of readdirSync(srcLocales)) {
+                  const srcFile = join(srcLocales, file);
 
-                    // Write .js (ESM named export format)
-                    const esmFile = join(distLocales, file);
-                    const esmContent = convertToESM(content);
-                    writeFileSync(esmFile, esmContent, 'utf-8');
-                  } else if (file.endsWith('.mjs')) {
-                    // ESM compiled files (from compileNamespace: 'es') — already correct format
-                    const srcFile = join(srcLocales, file);
+                  if (file.endsWith('.mjs')) {
                     const content = readFileSync(srcFile, 'utf-8');
-                    const baseName = file.replace('.mjs', '');
+                    const baseName = file.replace(/\.mjs$/, '');
 
-                    // Write .js only if not already created from a .js source above
-                    const jsFile = join(distLocales, `${baseName}.js`);
-                    if (!existsSync(jsFile)) {
-                      writeFileSync(jsFile, content, 'utf-8');
-                    }
+                    // ESM: same contents, .js extension for rslib import rewriting.
+                    writeFileSync(join(distLocales, `${baseName}.js`), content, 'utf-8');
 
-                    // Write .cjs only if not already created from a .js source above
-                    const cjsFile = join(distLocales, `${baseName}.cjs`);
-                    if (!existsSync(cjsFile)) {
-                      const cjsContent = content
-                        .replace(
-                          /\/\*eslint-disable\*\/export const messages=/,
-                          '/*eslint-disable*/module.exports={messages:'
-                        )
-                        .replace(/;$/, '};');
-                      writeFileSync(cjsFile, cjsContent, 'utf-8');
-                    }
+                    // CJS: synthesize from the known ESM shape.
+                    writeFileSync(
+                      join(distLocales, `${baseName}.cjs`),
+                      esmToCjs(content, srcFile),
+                      'utf-8'
+                    );
                   } else if (file.endsWith('.json')) {
-                    // Copy JSON files as-is
-                    const srcFile = join(srcLocales, file);
-                    const destFile = join(distLocales, file);
-                    const content = readFileSync(srcFile, 'utf-8');
-                    writeFileSync(destFile, content, 'utf-8');
+                    writeFileSync(join(distLocales, file), readFileSync(srcFile, 'utf-8'), 'utf-8');
                   }
                 }