feat(apollo-vertex): add page-header component to vertex registry#465
feat(apollo-vertex): add page-header component to vertex registry#465creilly11235 wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
0cf415e to
984815b
Compare
| }); | ||
|
|
||
| interface PageHeaderProps | ||
| extends React.ComponentProps<"div">, |
There was a problem hiding this comment.
import from react? same for other occurrences
| }: PageHeaderCollapsibleActionsProps) { | ||
| const containerRef = React.useRef<HTMLDivElement>(null); | ||
| const rulerRef = React.useRef<HTMLDivElement>(null); | ||
| const [visibleCount, setVisibleCount] = React.useState(-1); |
There was a problem hiding this comment.
why -1? wouldn't switching to null make more sense?
There was a problem hiding this comment.
I don't think you pushed the changes yet
There was a problem hiding this comment.
my bad, should be pushed now
| "use client"; | ||
|
|
||
| /* eslint-disable max-lines -- compound component with collapsible actions + skeletons */ | ||
| import { cva, type VariantProps } from "class-variance-authority"; |
There was a problem hiding this comment.
doesn't this need to be in the dependencies?
| @@ -0,0 +1,540 @@ | |||
| "use client"; | |||
|
|
|||
| /* eslint-disable max-lines -- compound component with collapsible actions + skeletons */ | |||
There was a problem hiding this comment.
im a bit offput by the size as well, not sure what others think, but I would prefer each component in each file
pieman1313
left a comment
There was a problem hiding this comment.
the old changes still show up, did you push the latest ones?
shouldn't we then switch to container queries instead of page widths? it would make this more reusable, since this will break as well if used in conjunction with the shell, right? |
984815b to
be335a5
Compare
be335a5 to
57a4b62
Compare
Port page-header compound component from vertical-medical-mrs to the apollo-vertex shadcn registry. Includes back navigation, title/description, metadata fields, collapsible actions with overflow dropdown, and skeleton loading state. Update shell preview with PageHeader in InvoiceDashboard and add InvoiceDetail page with back navigation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
57a4b62 to
b3b0eda
Compare
|
@pieman1313 should be updated and ready for review |


Summary
page-headercompound component from vertical-medical-mrs to the apollo-vertex shadcn registryScaledPreviewwrapper to simulate full-width layout in narrow docs containers🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com