Skip to content

fix(apollo-react): disable task three-dot menu while loading [MST-8171]#471

Merged
KodudulaAshishUiPath merged 1 commit intomainfrom
fix/MST-8171
Apr 16, 2026
Merged

fix(apollo-react): disable task three-dot menu while loading [MST-8171]#471
KodudulaAshishUiPath merged 1 commit intomainfrom
fix/MST-8171

Conversation

@KodudulaAshishUiPath
Copy link
Copy Markdown
Contributor

@KodudulaAshishUiPath KodudulaAshishUiPath commented Apr 8, 2026

Summary

  • Add loadingTaskIds prop to StageNode to track which tasks are currently loading
  • Disable three-dot menu button on tasks that are in a loading state (prevents delete/actions during async operations)
  • Apply same treatment to adhoc tasks
  • Replace addTaskLoading with loadingTaskIds for per-task granularity
  • Update tests and stories

Demo

Screen.Recording.2026-04-08.at.15.04.57.mov

Test plan

  • Verify three-dot menu button is disabled (greyed out) on loading tasks in storybook (AddTaskLoading story, third stage)
  • Verify three-dot menu button is enabled on non-loading tasks in the same stage
  • Verify right-click context menu is suppressed on loading tasks
  • Verify loading state clears and menu re-enables after async operation completes
  • Run DraggableTask.test.tsx — 4 new tests for loading state behavior
  • Run StageNode.test.tsx — updated tests use loadingTaskIds instead of addTaskLoading

Copilot AI review requested due to automatic review settings April 8, 2026 09:38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Apr 16, 2026, 04:26:43 AM
apollo-landing 🟢 Ready Preview, Logs Apr 16, 2026, 04:24:21 AM
apollo-ui-react 🟢 Ready Preview, Logs Apr 16, 2026, 04:25:39 AM
apollo-vertex 🟢 Ready Preview, Logs Apr 16, 2026, 04:25:55 AM

@github-actions github-actions Bot added the size:L 100-499 changed lines. label Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

Dependency License Review

  • 1941 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1701
ISC 89
Apache-2.0 61
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the StageNode task-loading model to support per-task loading state and uses it to suppress task menus/actions while async operations are in progress.

Changes:

  • Introduces loadingTaskIds on StageNode and wires it through to task renderers.
  • Disables the task “three-dot” menu button and suppresses right-click context menus for loading tasks (including adhoc tasks).
  • Updates StageNode/DraggableTask tests and stories to reflect the new loading-state behavior.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/apollo-react/src/canvas/components/StageNode/TaskMenu.tsx Adds disabled prop and blocks menu open via click/contextmenu when disabled.
packages/apollo-react/src/canvas/components/StageNode/StageNode.types.ts Replaces addTaskLoading with loadingTaskIds in public props.
packages/apollo-react/src/canvas/components/StageNode/StageNode.tsx Computes loading state and passes per-task loading flag down to task components; uses loading to disable add-task UX/toolbox.
packages/apollo-react/src/canvas/components/StageNode/StageNode.test.tsx Updates loading-related tests to use loadingTaskIds.
packages/apollo-react/src/canvas/components/StageNode/StageNode.stories.tsx Updates “AddTaskLoading” story and adds a per-task loading demo stage.
packages/apollo-react/src/canvas/components/StageNode/DraggableTask.types.ts Adds isTaskLoading prop.
packages/apollo-react/src/canvas/components/StageNode/DraggableTask.tsx Disables menu + suppresses right-click context menu when loading.
packages/apollo-react/src/canvas/components/StageNode/DraggableTask.test.tsx Adds tests around loading-state menu behavior.
packages/apollo-react/src/canvas/components/StageNode/AdhocTask.tsx Applies the same loading-state menu suppression to adhoc tasks.

Comment thread packages/apollo-react/src/canvas/components/StageNode/StageNode.types.ts Outdated
Comment thread packages/apollo-react/src/canvas/components/StageNode/TaskMenu.tsx Outdated
Comment thread packages/apollo-react/src/canvas/components/StageNode/DraggableTask.test.tsx Outdated
Comment thread packages/apollo-react/src/canvas/components/StageNode/AdhocTask.tsx
Comment thread packages/apollo-react/src/canvas/components/StageNode/StageNode.test.tsx Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Comment thread packages/apollo-react/src/canvas/components/StageNode/AdhocTask.tsx
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Comment thread packages/apollo-react/src/canvas/components/StageNode/TaskMenu.tsx Outdated
Comment thread packages/apollo-react/src/canvas/components/StageNode/TaskMenu.tsx Outdated
@uipath-utkarsh

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings April 13, 2026 13:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

@BenGSchulz
Copy link
Copy Markdown
Contributor

BenGSchulz commented Apr 14, 2026

Heads up: apollo-react v4 breaking change landed on main

main now contains a breaking change that bumps apollo-react to v4.x — see #482 (feat(apollo-react)!: canvas wind integration [MST-8290]). Your PR targets main, so when it merges it will ship as part of v4.

If your changes also need to ship as a v3.x patch, a maintenance branch is now available:

  • Branch: support/apollo-react@3.x (cut from @uipath/apollo-react@3.71.0)
  • npm channel: latest-v3

To backport:

  1. Create a branch based on support/apollo-react@3.x and cherry-pick your commits onto it
  2. Open a separate PR targeting support/apollo-react@3.x
  3. Use conventional commit prefixes (fix:, feat:) — semantic-release will handle versioning and publish to the latest-v3 dist-tag

If your changes are only needed going forward on v4, no action required — just be aware that main now targets the v4 release line.

Questions? Ping @BenGSchulz.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

@KodudulaAshishUiPath KodudulaAshishUiPath merged commit 3d7c637 into main Apr 16, 2026
42 checks passed
@KodudulaAshishUiPath KodudulaAshishUiPath deleted the fix/MST-8171 branch April 16, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants