fix(apollo-react): disable task three-dot menu while loading [MST-8171]#471
fix(apollo-react): disable task three-dot menu while loading [MST-8171]#471KodudulaAshishUiPath merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
This PR updates the StageNode task-loading model to support per-task loading state and uses it to suppress task menus/actions while async operations are in progress.
Changes:
- Introduces
loadingTaskIdsonStageNodeand wires it through to task renderers. - Disables the task “three-dot” menu button and suppresses right-click context menus for loading tasks (including adhoc tasks).
- Updates StageNode/DraggableTask tests and stories to reflect the new loading-state behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/components/StageNode/TaskMenu.tsx | Adds disabled prop and blocks menu open via click/contextmenu when disabled. |
| packages/apollo-react/src/canvas/components/StageNode/StageNode.types.ts | Replaces addTaskLoading with loadingTaskIds in public props. |
| packages/apollo-react/src/canvas/components/StageNode/StageNode.tsx | Computes loading state and passes per-task loading flag down to task components; uses loading to disable add-task UX/toolbox. |
| packages/apollo-react/src/canvas/components/StageNode/StageNode.test.tsx | Updates loading-related tests to use loadingTaskIds. |
| packages/apollo-react/src/canvas/components/StageNode/StageNode.stories.tsx | Updates “AddTaskLoading” story and adds a per-task loading demo stage. |
| packages/apollo-react/src/canvas/components/StageNode/DraggableTask.types.ts | Adds isTaskLoading prop. |
| packages/apollo-react/src/canvas/components/StageNode/DraggableTask.tsx | Disables menu + suppresses right-click context menu when loading. |
| packages/apollo-react/src/canvas/components/StageNode/DraggableTask.test.tsx | Adds tests around loading-state menu behavior. |
| packages/apollo-react/src/canvas/components/StageNode/AdhocTask.tsx | Applies the same loading-state menu suppression to adhoc tasks. |
86f9cde to
f81530c
Compare
f81530c to
bbb2a42
Compare
bbb2a42 to
06383ec
Compare
06383ec to
41da98c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
41da98c to
25ad96e
Compare
25ad96e to
c1f6275
Compare
Heads up:
|
c1f6275 to
d40783b
Compare
d40783b to
eb9f5b8
Compare
Summary
loadingTaskIdsprop toStageNodeto track which tasks are currently loadingaddTaskLoadingwithloadingTaskIdsfor per-task granularityDemo
Screen.Recording.2026-04-08.at.15.04.57.mov
Test plan
AddTaskLoadingstory, third stage)DraggableTask.test.tsx— 4 new tests for loading state behaviorStageNode.test.tsx— updated tests useloadingTaskIdsinstead ofaddTaskLoading