cherry pick fix to Spurious Closed Pipes (ROBO-3083)

Author: eduard-dumitru

src/UiPath.CoreIpc/Polyfills.cs src/IpcSample.ConsoleClient/Polyfills.cssrc/UiPath.CoreIpc/Polyfills.cs renamed to src/IpcSample.ConsoleClient/Polyfills.cs

@@ -1,4 +1,5 @@
 using System.Globalization;
+using System.IO.Pipes;
 using System.Reflection;
 using System.Runtime.InteropServices;
 using System.Text;

src/UiPath.CoreIpc.Tests/Implementation/SystemService.cs

@@ -1,6 +1,11 @@
 namespace UiPath.CoreIpc;
 using static TaskCompletionPool<Response>;
 using static IOHelpers;
+using System.IO.Pipes;
+using System.IO;
+using System.Threading;
+using Microsoft.Extensions.Logging;
+
 public sealed class Connection : IDisposable
 {
     private static readonly IOException ClosedException = new("Connection closed.");
@@ -183,14 +188,32 @@ private async ValueTask<bool> ReadBuffer(int length)
     {
         int offset = 0;
         int toRead = length;
+
         do
         {
-            var read = await Network.ReadAsync(
+            int read;
+            try
+            {
+                read = await Network.ReadAsync(
 #if NET461
-                _buffer, offset, toRead);
+                    _buffer, offset, toRead);
 #else
-                _buffer.AsMemory(offset, toRead));
+                    _buffer.AsMemory(offset, toRead));
 #endif
+            }
+            catch (OperationCanceledException ex) when (Network is PipeStream)
+            {
+                // Originally we decided to throw this exception the 2nd time we caught it, but later it was discovered that the NodeJS runtime continuosly retries.
+
+                // In some Windows client environments, OperationCanceledException is sporadically thrown on named pipe ReadAsync operation (ERROR_OPERATION_ABORTED on overlapped ReadFile)
+                // The cause has not yet been discovered(os specific, antiviruses, monitoring application), and we have implemented a retry system
+                // ROBO-3083
+
+                Logger.LogException(ex, $"Retrying ReadAsync for {Network.GetType()}");
+                await Task.Delay(10); //Without this delay, on net framework can get OperationCanceledException on the second ReadAsync call
+                continue;
+            }
+
             if (read == 0)
             {
                 return false;
@@ -319,7 +342,7 @@ private void OnCancellationReceived(string requestId)
         {
             CancellationReceived(requestId);
         }
-        catch(Exception ex)
+        catch (Exception ex)
         {
             Log(ex);
         }

src/UiPath.CoreIpc/Connection.cs

@@ -0,0 +1,30 @@
+#if NETFRAMEWORK
+
+namespace System.Diagnostics.CodeAnalysis;
+
+using static AttributeTargets;
+
+[ExcludeFromCodeCoverage]
+[DebuggerNonUserCode]
+[AttributeUsage(Parameter | Property | ReturnValue, AllowMultiple = true)]
+internal sealed class NotNullIfNotNullAttribute : Attribute
+{
+    /// <summary>
+    ///   Gets the associated parameter name.
+    ///   The output will be non-<see langword="null"/> if the argument to the
+    ///   parameter specified is non-<see langword="null"/>.
+    /// </summary>
+    public string ParameterName { get; }
+
+    /// <summary>
+    ///   Initializes the attribute with the associated parameter name.
+    /// </summary>
+    /// <param name="parameterName">
+    ///   The associated parameter name.
+    ///   The output will be non-<see langword="null"/> if the argument to the
+    ///   parameter specified is non-<see langword="null"/>.
+    /// </param>
+    public NotNullIfNotNullAttribute(string parameterName) =>
+        ParameterName = parameterName;
+}
+#endif