decommission cryptography

Author: eduard-dumitru

src/UiPath.CoreIpc/Client/ClientConnectionsRegistry.cs

@@ -35,7 +35,6 @@ internal static ClientConnection Remove(IConnectionKey connectionKey)
 }
 interface IConnectionKey : IEquatable<IConnectionKey>
 {
-    string SslServer { get; }
     ClientConnection CreateClientConnection();
 }
 abstract class ClientConnection : IDisposable

src/UiPath.CoreIpc/Client/ServiceClient.cs

@@ -24,18 +24,16 @@ class ServiceClient<TInterface> : IServiceClient, IConnectionKey where TInterfac
     private Server _server;
     private ClientConnection _clientConnection;
 
-    internal ServiceClient(ISerializer serializer, TimeSpan requestTimeout, ILogger logger, ConnectionFactory connectionFactory, string sslServer = null, BeforeCallHandler beforeCall = null, EndpointSettings serviceEndpoint = null)
+    internal ServiceClient(ISerializer serializer, TimeSpan requestTimeout, ILogger logger, ConnectionFactory connectionFactory, BeforeCallHandler beforeCall = null, EndpointSettings serviceEndpoint = null)
     {
         _serializer = serializer;
         _requestTimeout = requestTimeout;
         _logger = logger;
         _connectionFactory = connectionFactory;
-        SslServer = sslServer;
         _beforeCall = beforeCall;
         _serviceEndpoint = serviceEndpoint;
     }
     protected int HashCode { get; init; }
-    public string SslServer { get; init; }
     public virtual string Name => _connection?.Name;
     private bool LogEnabled => _logger.Enabled();
     Connection IServiceClient.Connection => _connection;
@@ -190,9 +188,8 @@ private async Task<bool> Connect(CancellationToken cancellationToken)
             {
                 clientConnection.Dispose();
                 throw;
-            }
-            var stream = SslServer == null ? network : await AuthenticateAsClient(network);
-            OnNewConnection(new(stream, _serializer, _logger, Name));
+            }            
+            OnNewConnection(new(network, _serializer, _logger, Name));
             if (LogEnabled)
             {
                 Log($"CreateConnection {Name}.");
@@ -204,21 +201,6 @@ private async Task<bool> Connect(CancellationToken cancellationToken)
             clientConnection.Release();
         }
         return true;
-        async Task<Stream> AuthenticateAsClient(Stream network)
-        {
-            var sslStream = new SslStream(network);
-            try
-            {
-                await sslStream.AuthenticateAsClientAsync(SslServer);
-            }
-            catch
-            {
-                sslStream.Dispose();
-                throw;
-            }
-            Debug.Assert(sslStream.IsEncrypted && sslStream.IsSigned);
-            return sslStream;
-        }
     }
 
     private void ReuseClientConnection(ClientConnection clientConnection)
@@ -276,7 +258,7 @@ protected virtual void Dispose(bool disposing)
 
     public override string ToString() => Name;
 
-    public virtual bool Equals(IConnectionKey other) => SslServer == other.SslServer;
+    public virtual bool Equals(IConnectionKey other) => true;
 
     public virtual ClientConnection CreateClientConnection() => throw new NotImplementedException();
 }

src/UiPath.CoreIpc/Client/ServiceClientBuilder.cs

@@ -13,7 +13,6 @@ public abstract class ServiceClientBuilder<TDerived, TInterface> where TInterfac
     protected BeforeCallHandler _beforeCall;
     protected object _callbackInstance;
     protected TaskScheduler _taskScheduler;
-    protected string _sslServer;
 
     protected ServiceClientBuilder(Type callbackContract, IServiceProvider serviceProvider)
     {
@@ -31,16 +30,6 @@ public TDerived ConnectionFactory(ConnectionFactory connectionFactory)
         return (TDerived)this;
     }
 
-    public TDerived EncryptAndSign(string certificateServerName)
-    {
-        if (string.IsNullOrWhiteSpace(certificateServerName))
-        {
-            throw new ArgumentException($"'{nameof(certificateServerName)}' must match the name on the server's certificate.", nameof(certificateServerName));
-        }
-        _sslServer = certificateServerName;
-        return (TDerived)this;
-    }
-
     public TDerived BeforeCall(BeforeCallHandler beforeCall)
     {
         _beforeCall = beforeCall;

src/UiPath.CoreIpc/NamedPipe/NamedPipeClient.cs

@@ -15,13 +15,13 @@ interface INamedPipeKey : IConnectionKey
 
 class NamedPipeClient<TInterface> : ServiceClient<TInterface>, INamedPipeKey where TInterface : class
 {
-    public NamedPipeClient(string serverName, string pipeName, ISerializer serializer, TimeSpan requestTimeout, bool allowImpersonation, ILogger logger, ConnectionFactory connectionFactory, string sslServer, BeforeCallHandler beforeCall, EndpointSettings serviceEndpoint)
-        : base(serializer, requestTimeout, logger, connectionFactory, sslServer, beforeCall, serviceEndpoint)
+    public NamedPipeClient(string serverName, string pipeName, ISerializer serializer, TimeSpan requestTimeout, bool allowImpersonation, ILogger logger, ConnectionFactory connectionFactory, BeforeCallHandler beforeCall, EndpointSettings serviceEndpoint)
+        : base(serializer, requestTimeout, logger, connectionFactory, beforeCall, serviceEndpoint)
     {
         ServerName = serverName;
         PipeName = pipeName;
         AllowImpersonation = allowImpersonation;
-        HashCode = (serverName, pipeName, allowImpersonation, sslServer).GetHashCode();
+        HashCode = (serverName, pipeName, allowImpersonation).GetHashCode();
     }
     public override string Name => base.Name ?? PipeName;
     public string ServerName { get; }

src/UiPath.CoreIpc/NamedPipe/NamedPipeClientBuilder.cs

@@ -27,7 +27,7 @@ public TDerived AllowImpersonation()
     }
 
     protected override TInterface BuildCore(EndpointSettings serviceEndpoint) =>
-        new NamedPipeClient<TInterface>(_serverName, _pipeName, _serializer, _requestTimeout, _allowImpersonation, _logger, _connectionFactory, _sslServer, _beforeCall, serviceEndpoint).CreateProxy();
+        new NamedPipeClient<TInterface>(_serverName, _pipeName, _serializer, _requestTimeout, _allowImpersonation, _logger, _connectionFactory, _beforeCall, serviceEndpoint).CreateProxy();
 }
 
 public class NamedPipeClientBuilder<TInterface> : NamedPipeClientBuilderBase<NamedPipeClientBuilder<TInterface>, TInterface> where TInterface : class

src/UiPath.CoreIpc/Tcp/TcpClient.cs

@@ -11,10 +11,10 @@ interface ITcpKey : IConnectionKey
 }
 class TcpClient<TInterface> : ServiceClient<TInterface>, ITcpKey where TInterface : class
 {
-    public TcpClient(IPEndPoint endPoint, ISerializer serializer, TimeSpan requestTimeout, ILogger logger, ConnectionFactory connectionFactory, string sslServer, BeforeCallHandler beforeCall, EndpointSettings serviceEndpoint) : base(serializer, requestTimeout, logger, connectionFactory, sslServer, beforeCall, serviceEndpoint)
+    public TcpClient(IPEndPoint endPoint, ISerializer serializer, TimeSpan requestTimeout, ILogger logger, ConnectionFactory connectionFactory, BeforeCallHandler beforeCall, EndpointSettings serviceEndpoint) : base(serializer, requestTimeout, logger, connectionFactory, beforeCall, serviceEndpoint)
     {
         EndPoint = endPoint;
-        HashCode = (EndPoint, sslServer).GetHashCode();
+        HashCode = EndPoint.GetHashCode();
     }
     public override string Name => base.Name ?? EndPoint.ToString();
     public IPEndPoint EndPoint { get; }

src/UiPath.CoreIpc/Tcp/TcpClientBuilder.cs

@@ -10,7 +10,7 @@ protected TcpClientBuilderBase(IPEndPoint endPoint, Type callbackContract = null
         _endPoint = endPoint;
 
     protected override TInterface BuildCore(EndpointSettings serviceEndpoint) =>
-        new TcpClient<TInterface>(_endPoint, _serializer, _requestTimeout, _logger, _connectionFactory, _sslServer, _beforeCall, serviceEndpoint).CreateProxy();
+        new TcpClient<TInterface>(_endPoint, _serializer, _requestTimeout, _logger, _connectionFactory, _beforeCall, serviceEndpoint).CreateProxy();
 }
 
 public class TcpClientBuilder<TInterface> : TcpClientBuilderBase<TcpClientBuilder<TInterface>, TInterface> where TInterface : class

src/UiPath.CoreIpc/WebSockets/WebSocketClient.cs

@@ -8,10 +8,10 @@ interface IWebSocketsKey : IConnectionKey
 }
 class WebSocketClient<TInterface> : ServiceClient<TInterface>, IWebSocketsKey where TInterface : class
 {
-    public WebSocketClient(Uri uri, ISerializer serializer, TimeSpan requestTimeout, ILogger logger, ConnectionFactory connectionFactory, string sslServer, BeforeCallHandler beforeCall, EndpointSettings serviceEndpoint) : base(serializer, requestTimeout, logger, connectionFactory, sslServer, beforeCall, serviceEndpoint)
+    public WebSocketClient(Uri uri, ISerializer serializer, TimeSpan requestTimeout, ILogger logger, ConnectionFactory connectionFactory, BeforeCallHandler beforeCall, EndpointSettings serviceEndpoint) : base(serializer, requestTimeout, logger, connectionFactory, beforeCall, serviceEndpoint)
     {
         Uri = uri;
-        HashCode = (uri, sslServer).GetHashCode();
+        HashCode = uri.GetHashCode();
     }
     public override string Name => base.Name ?? Uri.ToString();
     public Uri Uri { get; }

src/UiPath.CoreIpc/WebSockets/WebSocketClientBuilder.cs

@@ -5,7 +5,7 @@ public abstract class WebSocketClientBuilderBase<TDerived, TInterface> : Service
     protected WebSocketClientBuilderBase(Uri uri, Type callbackContract = null, IServiceProvider serviceProvider = null) : base(callbackContract, serviceProvider) =>
         _uri = uri;
     protected override TInterface BuildCore(EndpointSettings serviceEndpoint) =>
-        new WebSocketClient<TInterface>(_uri, _serializer, _requestTimeout, _logger, _connectionFactory, _sslServer, _beforeCall, serviceEndpoint).CreateProxy();
+        new WebSocketClient<TInterface>(_uri, _serializer, _requestTimeout, _logger, _connectionFactory, _beforeCall, serviceEndpoint).CreateProxy();
 }
 public class WebSocketClientBuilder<TInterface> : WebSocketClientBuilderBase<WebSocketClientBuilder<TInterface>, TInterface> where TInterface : class
 {