Skip to content

fix: Fixing Offset in Query Command#478

Open
AditiGoyalUipath wants to merge 1 commit into
mainfrom
fix/QueryOffset
Open

fix: Fixing Offset in Query Command#478
AditiGoyalUipath wants to merge 1 commit into
mainfrom
fix/QueryOffset

Conversation

@AditiGoyalUipath
Copy link
Copy Markdown
Contributor

Added offset parameter as part of CLI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Claude finished @AditiGoyalUipath's task in 1m 40s —— View job


Review: PR #478 — fix: Fixing Offset in Query Command

  • Read review criteria and project conventions
  • Read existing PR conversation
  • Analyze full diff
  • Read full changed files for context
  • Run skill-specific checks (links, cross-refs, secrets, CODEOWNERS)
  • Post review feedback

Summary

Adds --offset as a new CLI pagination flag for records list and records query, documented as mutually exclusive with --cursor and requiring @uipath/data-fabric-tool 1.0.0+. Changes span SKILL.md (task table + query format section) and references/records-query.md (list and query examples, response field descriptions).

Change-by-Change Review

1. skills/uipath-data-fabric/SKILL.md

Severity: Low

The task navigation table (lines 101–102) and query format section (line 142) are updated correctly. Version requirement and mutual exclusivity constraint are clearly stated.

One minor inconsistency: line 161 still reads:

Response includes HasNextPage and NextCursor — pass NextCursor to --cursor for the next page

This only describes cursor-mode pagination. Now that offset is documented, this line should mention offset-mode pagination too (e.g., "or increment --offset by --limit"), matching what records-query.md:27-28 already says. Not blocking, but the asymmetry could confuse an agent using SKILL.md without loading the reference.

Fix this →

2. skills/uipath-data-fabric/references/records-query.md

Severity: OK

Well-structured changes:

  • Clear two-mode pagination intro (line 5) with mutual exclusivity stated upfront
  • Separate code blocks for cursor vs offset with inline version note (lines 7–22)
  • Response field bullets updated to explain both modes (lines 26–28)
  • Query section updated with both cursor and offset examples (lines 38–53)
  • Body schema callout updated to include --offset (line 74)

No issues found. The reference file is internally consistent and provides clear, copy-paste-ready examples for both pagination modes.

What's Missing

  • SKILL.md line 161 — Response description only covers cursor pagination; should also mention offset mode for consistency with records-query.md. (Low)
  • No test coverage for offset pagination — The existing integration_large_pagination.yaml and integration_query_filters.yaml tests don't mention --offset. Since this is a new CLI capability, a test task validating offset-based pagination would be valuable. (Medium — consistent with existing test gaps in the repo)

Area Ratings

Area Status Notes
Frontmatter OK No frontmatter changes
E2E Tests Issue No test task for --offset pagination (Medium)
Skill Body Issue Line 161 response description incomplete (Low)
References & Assets OK records-query.md changes are clean and consistent
Repo Hygiene OK CODEOWNERS present, no secrets, no cross-skill refs, all links resolve

Issues for Manual Review

  • CLI flag correctness — Cannot verify that --offset is an actual flag on uip df records list / records query in tool version 1.0.0+. The PR author should confirm against the actual CLI --help output.
  • Response shape with offset — The reference states offset mode may return CurrentPage? and TotalPages? (line 24). Confirm these fields are actually returned by the API when using offset pagination.

Conclusion

Clean, well-scoped documentation change. The offset/cursor mutual exclusivity is consistently documented across both files. One low-severity consistency gap in SKILL.md (line 161) and a medium-severity gap in test coverage. Recommend approving after addressing the SKILL.md line 161 inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant