fix(hitl): align maestro-flow skill and tests to v1.0 output variable path#528
Conversation
|
Claude finished @dushyant-uipath's task in 2m 34s —— View job PR Review: fix(hitl) — align docs and eval tests to v1.0 output variable pathSummaryBulk rename across 15 files: HITL node v1.0 changed Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | No frontmatter changes — existing frontmatter valid |
| E2E Tests | OK | All 8 affected test files consistently updated |
| Skill Body | Issue | 1 stale result reference in apptask.md |
| References & Assets | Issue | 1 stale JSON code block in impl.md contradicts its own prose |
| Repo Hygiene | OK | No secrets, no cross-skill refs, CODEOWNERS entries exist, changes scoped correctly |
Issues for Manual Review
- The PR description notes
status.sourcechanged from=statusto=result.Action— verify this is the actual v1.0 runtime behavior in flow-workbench. The code block inimpl.mdwas not updated (flagged above), which suggests this detail may have been overlooked rather than intentionally left. "version": "1.0"vs"typeVersion": "1.0.0"— the definition entry now uses"1.0"while node instances elsewhere still use"typeVersion": "1.0.0". Confirm whether these are intentionally different fields with different versioning schemes.- The
forbiddenSourceCategoriesremoval from the input handle is a behavioral change — confirm that v1.0 no longer enforces this constraint.
Conclusion
Clean, well-scoped rename PR. Two stale references were missed — both are in code blocks/prose that should have been updated as part of the same .result → .output migration. Recommend fixing those two items before merging to avoid agents generating incorrect JSON.
4fd2975 to
d1e3f29
Compare
… path Update all uipath-maestro-flow skill references and eval tests to use $vars.<nodeId>.output (not .result) and status source =result.Action following the v1.0 node schema rename. - Fix impl.md Quick Reference node JSON: outputs.output (not result), status source =result.Action - Add DevCon e2e scenario: expense approval flow combining maestro-flow and HITL skills, validates the full authoring lifecycle end-to-end Affected files: impl.md, planning.md, cli-commands.md, quality_01/02/03 and smoke_03 eval tests, and new devcon_expense_approval.yaml e2e test.
d1e3f29 to
7ea3f53
Compare
Summary
Updates
skills/uipath-maestro-flowandtests/tasks/uipath-maestro-flowto use$vars.<nodeId>.output(not.result) andstatus source =result.Actionfollowing the v1.0 HITL node schema rename.Files changed
skills/uipath-maestro-flow/references/author/references/plugins/hitl/impl.md— Quick Reference JSON fixed:outputs.output(notresult),status.source = "=result.Action"skills/uipath-maestro-flow/references/author/references/plugins/hitl/planning.mdskills/uipath-maestro-flow/references/shared/cli-commands.mdtests/tasks/uipath-maestro-flow/hitl/quality_01_schema_design.yamltests/tasks/uipath-maestro-flow/hitl/quality_02_result_downstream.yamltests/tasks/uipath-maestro-flow/hitl/quality_03_boolean_decision.yamltests/tasks/uipath-maestro-flow/hitl/smoke_03_multi_outcome_routing.yamltests/tasks/uipath-maestro-flow/e2e/devcon_expense_approval.yaml(new) — DevCon end-to-end scenario: vague expense approval requirement, agent builds full flow with HITL using both maestro-flow and HITL skillsTest plan
quality_01,quality_02,quality_03,smoke_03pass with updated.outputpathsdevcon_expense_approvalpasses end-to-end: solution creation, flow init, hitl add, validate