Skip to content

fix(hitl): replace vestigial 'HITL result' natural-language in quality_02 prompt#547

Merged
tmatup merged 2 commits into
mainfrom
tmatup/mst-9345-quality_02-prompt-text
May 4, 2026
Merged

fix(hitl): replace vestigial 'HITL result' natural-language in quality_02 prompt#547
tmatup merged 2 commits into
mainfrom
tmatup/mst-9345-quality_02-prompt-text

Conversation

@tmatup
Copy link
Copy Markdown
Member

@tmatup tmatup commented May 4, 2026

Summary

  • One-word fix: line 27 of tests/tasks/uipath-maestro-flow/hitl/quality_02_result_downstream.yaml says "reads the reviewer's decision from the HITL result" while line 28 already says "the HITL output". After the v1.0 schema rename (#528 / #529.result.output), the natural-language descriptions in test prompts should also use "output" consistently. This is a follow-up to a bot review nit on closed PR fix(hitl): align maestro-flow HITL docs + tests to v1.0 schema (.output not .result) #544.

Background

PR #544 (fix(hitl): align maestro-flow HITL docs + tests to v1.0 schema (.output not .result)) overlapped substantially with #528 and was closed when #528 landed. However, the bot review on #544 caught one additional inconsistency that #528 didn't fix — line 27 of quality_02_result_downstream.yaml. This PR carries just that one-word fix forward onto current main.

Test plan

  • Diff is one line — resultoutput on line 27 of the test prompt.
  • Surrounding lines (28+) already use "HITL output"; this completes consistency.
  • No code or schema changes; pure prompt-text fix.

🤖 Generated with Claude Code

…y_02 prompt

PR #544 bot review nit: quality_02_result_downstream.yaml line 27 still said
"reads the reviewer's decision from the HITL result" while line 29 already
says "the HITL output". Replace for full consistency.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Claude finished @tmatup's task in 54s —— View job


Review: fix(hitl): replace vestigial 'HITL result' natural-language in quality_02 prompt

  • Gather context (review criteria, project conventions, diff)
  • Read full changed file for surrounding context
  • Check for remaining inconsistencies across sibling test files
  • Post review

Summary

One-word fix in quality_02_result_downstream.yaml line 27: "HITL result" → "HITL output" to align natural-language prompt text with the v1.0 schema rename (.result.output) landed in #528.

Change-by-Change Review

1. tests/tasks/uipath-maestro-flow/hitl/quality_02_result_downstream.yamlOK

The fix is correct. Line 27 now says "HITL output", matching line 28 ("HITL output via the correct runtime variable path") and the .output references throughout the success_criteria section (lines 64–65, 82). The file is internally consistent after this change.

What's Missing

Low — Same "HITL result" phrasing persists in two sibling test files. This PR fixes quality_02 but the identical vestigial wording remains in:

  • tests/tasks/uipath-maestro-flow/hitl/quality_03_boolean_decision.yaml:28"from the HITL result:"
  • tests/tasks/uipath-maestro-flow/hitl/smoke_03_multi_outcome_routing.yaml:26"from the HITL result"
  • tests/tasks/uipath-maestro-flow/hitl/smoke_03_multi_outcome_routing.yaml:33"reference the HITL result using the"

These are the same class of inconsistency this PR fixes. Consider bundling them into this PR for a clean sweep — or tracking a follow-up.

Area Ratings

Area Status Notes
Frontmatter N/A No frontmatter changes
E2E Tests OK Test file content updated, structure intact
Skill Body N/A No skill body changes
References & Assets N/A No reference/asset changes
Repo Hygiene OK Scoped change, no secrets, no cross-skill refs

Issues for Manual Review

None found.

Conclusion

Approve. The one-word fix is correct and makes quality_02_result_downstream.yaml internally consistent. The only observation is that three other test files have the same vestigial "HITL result" phrasing — worth fixing in this PR or a follow-up.

…tests

Bot review on #547 caught three more instances of the same vestigial
"HITL result" wording in adjacent maestro-flow HITL test prompts that
the original cherry-pick missed:

- quality_03_boolean_decision.yaml:28 — "from the HITL result:"
- smoke_03_multi_outcome_routing.yaml:26 — "from the HITL result"
- smoke_03_multi_outcome_routing.yaml:33 — "reference the HITL result using the"

All three rewritten to "HITL output" to match the v1.0 schema rename.
The smoke_03:33 occurrence was particularly clear — the very next line
already uses `$vars.<nodeId>.output.<fieldName>` while the prose said
"HITL result", so the prompt was internally inconsistent.

`grep -rn "HITL result" tests/tasks/uipath-maestro-flow/hitl/` now
returns no matches.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@tmatup
Copy link
Copy Markdown
Member Author

tmatup commented May 4, 2026

Review Response

1. Same "HITL result" phrasing persists in two sibling test filestests/tasks/uipath-maestro-flow/hitl/{quality_03_boolean_decision.yaml:28, smoke_03_multi_outcome_routing.yaml:26, smoke_03_multi_outcome_routing.yaml:33}

Fixed in f547a9a. Verified all three flagged occurrences and swept them in. The smoke_03:33 case was especially clear — the very next line already uses $vars.<nodeId>.output.<fieldName> while the prose said "HITL result," so the prompt was internally inconsistent. After the fix, grep -rn "HITL result" tests/tasks/uipath-maestro-flow/hitl/ returns no matches.

PR title still accurately describes the intent (vestigial "HITL result" → "HITL output" cleanup); now does it as a complete sweep across the four files in hitl/ rather than just one. Diff is now 4 single-word edits across 3 files.

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

@tmatup tmatup merged commit 6270904 into main May 4, 2026
6 of 7 checks passed
@tmatup tmatup deleted the tmatup/mst-9345-quality_02-prompt-text branch May 4, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants