|
1 | 1 | """Tests for agent/messages/message_utils.py module.""" |
2 | 2 |
|
3 | | -from langchain.messages import AIMessage, ToolCall |
| 3 | +from typing import Any, Union |
| 4 | + |
| 5 | +from langchain.messages import AIMessage, HumanMessage, ToolCall |
| 6 | +from langchain_core.messages import BaseMessage |
4 | 7 | from langchain_core.messages.content import ( |
5 | 8 | ContentBlock, |
6 | 9 | create_text_block, |
7 | 10 | create_tool_call, |
8 | 11 | ) |
| 12 | +from langgraph.graph.message import add_messages |
9 | 13 |
|
10 | 14 | from uipath_langchain.agent.messages.message_utils import replace_tool_calls |
11 | 15 |
|
| 16 | +MessageItem = Union[BaseMessage, list[str], tuple[str, str], str, dict[str, Any]] |
| 17 | + |
12 | 18 |
|
13 | 19 | class TestReplaceToolCalls: |
14 | 20 | """Test cases for replace_tool_calls function.""" |
@@ -179,6 +185,74 @@ def test_replace_tool_calls_no_original_metadata(self): |
179 | 185 | assert len(tool_call_blocks) == 1 |
180 | 186 | assert tool_call_blocks[0]["name"] == "new_tool" |
181 | 187 |
|
| 188 | + def test_replace_tool_calls_preserves_message_id(self): |
| 189 | + """Test that the original message id is preserved after replacement.""" |
| 190 | + original_tool_calls = [ToolCall(name="old_tool", args={}, id="old_id")] |
| 191 | + original_content_blocks: list[ContentBlock] = [ |
| 192 | + create_text_block("Test message"), |
| 193 | + create_tool_call(name="old_tool", args={}, id="old_id"), |
| 194 | + ] |
| 195 | + original_message = AIMessage( |
| 196 | + content_blocks=original_content_blocks, |
| 197 | + tool_calls=original_tool_calls, |
| 198 | + id="msg-original-id", |
| 199 | + ) |
| 200 | + |
| 201 | + new_tool_calls = [ToolCall(name="new_tool", args={}, id="new_id")] |
| 202 | + |
| 203 | + result = replace_tool_calls(original_message, new_tool_calls) |
| 204 | + |
| 205 | + assert result.id == "msg-original-id" |
| 206 | + |
| 207 | + def test_replace_tool_calls_updated_args_visible_via_add_messages(self): |
| 208 | + """Test that updated tool call args are visible after add_messages processes them. |
| 209 | +
|
| 210 | + Reproduces the HITL bug: when a human reviews and updates activity input |
| 211 | + during an escalation, the activity must execute with the reviewed args. |
| 212 | + Without id preservation, add_messages appends a duplicate AIMessage |
| 213 | + instead of replacing the original, causing the tool to run with stale args. |
| 214 | + """ |
| 215 | + original_tool_calls = [ |
| 216 | + ToolCall(name="my_activity", args={"input": "original_value"}, id="call_1") |
| 217 | + ] |
| 218 | + original_ai_message = AIMessage( |
| 219 | + content_blocks=[ |
| 220 | + create_text_block("I will invoke the activity"), |
| 221 | + create_tool_call( |
| 222 | + name="my_activity", args={"input": "original_value"}, id="call_1" |
| 223 | + ), |
| 224 | + ], |
| 225 | + tool_calls=original_tool_calls, |
| 226 | + id="msg-from-llm", |
| 227 | + ) |
| 228 | + |
| 229 | + messages: list[MessageItem] = [ |
| 230 | + HumanMessage(content="do something", id="msg-human"), |
| 231 | + original_ai_message, |
| 232 | + ] |
| 233 | + |
| 234 | + # Simulate HITL review: human changes the input |
| 235 | + reviewed_tool_calls = [ |
| 236 | + ToolCall(name="my_activity", args={"input": "reviewed_value"}, id="call_1") |
| 237 | + ] |
| 238 | + updated_ai_message = replace_tool_calls( |
| 239 | + original_ai_message, reviewed_tool_calls |
| 240 | + ) |
| 241 | + |
| 242 | + # Simulate what Command(update={"messages": [updated_ai_message]}) does |
| 243 | + new_messages: list[MessageItem] = [updated_ai_message] |
| 244 | + result_messages = add_messages(messages, new_messages) |
| 245 | + |
| 246 | + # There must be exactly one AIMessage — not a duplicate |
| 247 | + ai_messages = [m for m in result_messages if isinstance(m, AIMessage)] |
| 248 | + assert len(ai_messages) == 1, ( |
| 249 | + f"Expected 1 AIMessage but got {len(ai_messages)}; " |
| 250 | + "add_messages appended instead of replacing (id mismatch)" |
| 251 | + ) |
| 252 | + |
| 253 | + # The surviving AIMessage must carry the reviewed args |
| 254 | + assert ai_messages[0].tool_calls[0]["args"] == {"input": "reviewed_value"} |
| 255 | + |
182 | 256 | def test_replace_tool_calls_content_blocks(self): |
183 | 257 | """Test that non-tool content blocks are preserved.""" |
184 | 258 | original_tool_calls = [ToolCall(name="old_tool", args={}, id="old_id")] |
|
0 commit comments