fix: remove dead metadata var, check require_confirmation field, fix legacy hitl payload format

Author: JoshParkSJ

src/uipath_langchain/chat/hitl.py

@@ -149,11 +149,11 @@ def ask_confirmation():
         return tool_args
 
     # Handle both new and legacy payload shapes
-    if "value" in response and "type" in response:
-        # Legacy endInterrupt payload
+    if "value" in response:
+        # Legacy endInterrupt payload: {"type": ..., "value": {"approved": ..., "input": ...}}
         confirmation = response.get("value", response)
     else:
-        # New confirmToolCall payload
+        # New confirmToolCall payload: {"approved": bool, "input": ...}
         confirmation = response
 
     if not confirmation.get("approved", True):

src/uipath_langchain/runtime/messages.py

@@ -544,10 +544,6 @@ def map_tool_call_to_tool_call_start_event(
         require_confirmation: bool | None = None,
         input_schema: Any | None = None,
     ) -> UiPathConversationMessageEvent:
-        metadata = None
-        if tool_call["name"] in self.tool_names_requiring_confirmation:
-            metadata = {"requiresConfirmation": True}
-
         return UiPathConversationMessageEvent(
             message_id=message_id,
             tool_call=UiPathConversationToolCallEvent(

tests/runtime/test_chat_message_mapper.py

@@ -2029,7 +2029,7 @@ async def test_confirmation_tool_has_requires_confirmation_metadata(self):
         assert event.tool_call is not None
         assert event.tool_call.start is not None
         assert event.tool_call.start.tool_name == "confirm_tool"
-        assert event.tool_call.start.metadata == {"requiresConfirmation": True}
+        assert event.tool_call.start.require_confirmation is True
 
     @pytest.mark.asyncio
     async def test_normal_tool_has_no_confirmation_metadata(self):
@@ -2060,7 +2060,7 @@ async def test_normal_tool_has_no_confirmation_metadata(self):
         event = tool_start_events[0]
         assert event.tool_call is not None
         assert event.tool_call.start is not None
-        assert event.tool_call.start.metadata is None
+        assert event.tool_call.start.require_confirmation is None
 
     @pytest.mark.asyncio
     async def test_mixed_tools_only_confirmation_has_metadata(self):
@@ -2092,5 +2092,5 @@ async def test_mixed_tools_only_confirmation_has_metadata(self):
                 tool_starts[tc.start.tool_name] = tc.start
         assert "normal_tool" in tool_starts
         assert "confirm_tool" in tool_starts
-        assert tool_starts["normal_tool"].metadata is None
-        assert tool_starts["confirm_tool"].metadata == {"requiresConfirmation": True}
+        assert tool_starts["normal_tool"].require_confirmation is None
+        assert tool_starts["confirm_tool"].require_confirmation is True