Commit fd373f3
feat(datafabric ontology): full LLM-loop writes + run-script tracing
Makes the full LLM-in-the-loop refund flow persist writes end-to-end
(verified on staging dataservicetest/DataFabricFQS: insert RefundRequest +
update Order/CustomerRisk/Contact all success, read-back confirmed).
Root cause of the prior "writes planned but not dispatched": the write tool
hardcoded `require_conversational_confirmation: True`, whose tool-node gate
calls request_approval -> @durable_interrupt, suspending the graph for human
approval. In a non-conversational/coded agent (no human/checkpointer) the
graph suspended at the first write and ainvoke returned without executing it.
- datafabric_tool.py: drop the unconditional `require_conversational_
confirmation` from the write tool metadata. HITL confirmation is still
applied per-resource for conversational agents by tool_factory; it is no
longer forced on coded agents (where it can only deadlock). Deterministic
guardrails remain: writability checks, ontology op-validation, field
allowlist, read-only enforcement.
- run_agent_with_ontology.py: add --trace (DEBUG logging surfaces the inner
NL->SQL generated SQL per read), --api-flavor (default chat-completions),
and print tool RESPONSES (not just calls) so reads/writes are visible.
- test: assert the write tool no longer hardcodes the confirmation flag.
752 tests pass, ruff clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 90dffe6 commit fd373f3
3 files changed
Lines changed: 59 additions & 6 deletions
File tree
- scripts
- src/uipath_langchain/agent/tools/datafabric_tool
- tests/agent/tools/datafabric_tool
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| |||
278 | 279 | | |
279 | 280 | | |
280 | 281 | | |
281 | | - | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
282 | 294 | | |
283 | 295 | | |
284 | 296 | | |
| |||
386 | 398 | | |
387 | 399 | | |
388 | 400 | | |
389 | | - | |
| 401 | + | |
390 | 402 | | |
391 | 403 | | |
| 404 | + | |
| 405 | + | |
392 | 406 | | |
393 | 407 | | |
394 | 408 | | |
395 | 409 | | |
396 | 410 | | |
397 | | - | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
398 | 419 | | |
399 | 420 | | |
400 | 421 | | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
401 | 427 | | |
402 | 428 | | |
403 | 429 | | |
| |||
457 | 483 | | |
458 | 484 | | |
459 | 485 | | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
460 | 501 | | |
461 | 502 | | |
462 | 503 | | |
463 | 504 | | |
464 | 505 | | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
465 | 515 | | |
466 | 516 | | |
467 | 517 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
442 | 442 | | |
443 | 443 | | |
444 | 444 | | |
445 | | - | |
446 | 445 | | |
447 | 446 | | |
448 | 447 | | |
| |||
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
174 | | - | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
175 | 179 | | |
176 | 180 | | |
177 | 181 | | |
178 | | - | |
| 182 | + | |
179 | 183 | | |
180 | 184 | | |
181 | 185 | | |
| |||
0 commit comments