feat: confirmToolCall support — startToolCall with requireConfirmation + ToolRunnableCallable [JAR-9208]#703
Open
JoshParkSJ wants to merge 2 commits intomainfrom
Open
feat: confirmToolCall support — startToolCall with requireConfirmation + ToolRunnableCallable [JAR-9208]#703JoshParkSJ wants to merge 2 commits intomainfrom
JoshParkSJ wants to merge 2 commits intomainfrom
Conversation
maxduu
approved these changes
Mar 18, 2026
f129206 to
5700f6b
Compare
1eed1e2 to
f655a29
Compare
413c601 to
4d8b645
Compare
JoshParkSJ
commented
Apr 15, 2026
| Walks compiled graph nodes once at runtime init. This is needed because coded agents | ||
| (create_agent) export a compiled graph as the only artifact — there's no side channel | ||
| to pass confirmation metadata from the build step to the runtime. | ||
| """ |
Contributor
Author
There was a problem hiding this comment.
not a problem for low code agents, but might as well unify how we get tools requiring confirmation
…RunnableCallable [JAR-9208]
87b0fc5 to
aa8c53b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
confirmToolCallonstartToolCall:BaseToolreference; the typed subclass preserves.toolso the runtime can inspect it at init time (so we know which tools need confirmation before hitting the tool node and can pass require confirmation onstartToolCall)_get_tool_confirmation_infowalks the compiled graph once, findsConversationalToolRunnableCallablenodes, and builds a{tool_name: input_schema}lookup. This is needed because coded agents (create_agent) export a compiled graph as the only artifact — there's no side channel to pass confirmation metadata from the build step to the runtime.AIMessagetool call, emitsstartToolCallwithrequireConfirmation: trueandinputSchema.AIMessageChunkself-accumulation bug that doubled tool names on the first streamed chunk (only triggered with OpenAI, not Claude);startToolCallnow always emitted for confirmation toolsCompanion PRs
https://uipath.atlassian.net/browse/JAR-9208