Skip to content

Fix typing issues #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cosminacho merged 1 commit into from
Feb 26, 2026
Merged

Fix typing issues #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/uipath_langchain_client/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

All notable changes to `uipath_langchain_client` will be documented in this file.

## [1.2.5] - 2026-02-26

### Fix
- Parameters on factory fix

## [1.2.4] - 2026-02-26

### Fix
Expand Down
2 changes: 1 addition & 1 deletion packages/uipath_langchain_client/src/uipath_langchain_client/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
__title__ = "UiPath LangChain Client"
__description__ = "A Python client for interacting with UiPath's LLM services via LangChain."
__version__ = "1.2.4"
__version__ = "1.2.5"
11 changes: 9 additions & 2 deletions packages/uipath_langchain_client/src/uipath_langchain_client/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

def _get_model_info(
model_name: str,
*,
client_settings: UiPathBaseSettings,
byo_connection_id: str | None = None,
) -> dict[str, Any]:
Expand Down Expand Up @@ -67,6 +68,7 @@ def _get_model_info(

def get_chat_model(
model_name: str,
*,
byo_connection_id: str | None = None,
client_settings: UiPathBaseSettings | None = None,
client_type: Literal["passthrough", "normalized"] = "passthrough",
Expand All @@ -88,7 +90,9 @@ def get_chat_model(
ValueError: If the model is not found in available models or vendor is not supported
"""
client_settings = client_settings or get_default_client_settings()
model_info = _get_model_info(model_name, client_settings, byo_connection_id)
model_info = _get_model_info(
model_name, client_settings=client_settings, byo_connection_id=byo_connection_id
)
is_uipath_owned = model_info.get("modelSubscriptionType") == "UiPathOwned"
if not is_uipath_owned:
client_settings.validate_byo_model(model_info)
Expand Down Expand Up @@ -215,6 +219,7 @@ def get_chat_model(

def get_embedding_model(
model_name: str,
*,
byo_connection_id: str | None = None,
client_settings: UiPathBaseSettings | None = None,
client_type: Literal["passthrough", "normalized"] = "passthrough",
Expand Down Expand Up @@ -243,7 +248,9 @@ def get_embedding_model(
>>> vectors = embeddings.embed_documents(["Hello world"])
"""
client_settings = client_settings or get_default_client_settings()
model_info = _get_model_info(model_name, client_settings, byo_connection_id)
model_info = _get_model_info(
model_name, client_settings=client_settings, byo_connection_id=byo_connection_id
)
is_uipath_owned = model_info.get("modelSubscriptionType") == "UiPathOwned"
if not is_uipath_owned:
client_settings.validate_byo_model(model_info)
Expand Down