fix: address PR #159 review remarks

- Update uipath SDK to >=2.8.23 and add uipath-runtime >=0.8.0 dependency
- Use UiPathRuntimeContext for mcp_server_id/slug instead of manual uipath.json parsing
- Add get_settings() method to factory protocol
- Remove TODO comment on auth validation (confirmed needed)
- Remove manual tracing/LlmOpsHttpExporter setup (handled by CLI)
- Fix self.context.folder_key bug in _on_runtime_abort (use self._folder_key)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: edis-uipath

pyproject.toml

@@ -7,7 +7,8 @@ requires-python = ">=3.11"
 dependencies = [
     "mcp==1.24.0",
     "pysignalr==1.3.0",
-    "uipath>=2.2.16, <2.3.0",
+    "uipath>=2.8.23, <2.9.0",
+    "uipath-runtime>=0.8.0, <0.9.0",
 ]
 classifiers = [
     "Development Status :: 3 - Alpha",

src/uipath_mcp/_cli/_runtime/_factory.py

@@ -1,13 +1,11 @@
 """Factory for creating MCP runtime instances."""
 
-import json
 import logging
-import os
 import uuid
-from typing import Any
 
 from uipath.runtime import (
     UiPathRuntimeContext,
+    UiPathRuntimeFactorySettings,
     UiPathRuntimeProtocol,
 )
 from uipath.runtime.errors import UiPathErrorCategory
@@ -33,29 +31,6 @@ def __init__(
         """
         self.context = context
         self._mcp_config: McpConfig | None = None
-        self._server_id: str | None = None
-        self._server_slug: str | None = None
-
-        # Load fps context from uipath.json if available
-        self._load_fps_context()
-
-    def _load_fps_context(self) -> None:
-        """
-        Load fps context from uipath.json for server registration.
-        """
-        config_path = self.context.config_path or "uipath.json"
-        if os.path.exists(config_path):
-            try:
-                with open(config_path, "r") as f:
-                    config: dict[str, Any] = json.load(f)
-
-                config_runtime = config.get("runtime", {})
-                if "fpsContext" in config_runtime:
-                    fps_context = config_runtime["fpsContext"]
-                    self._server_id = fps_context.get("Id")
-                    self._server_slug = fps_context.get("Slug")
-            except Exception as e:
-                logger.warning(f"Failed to load fps context: {e}")
 
     def _load_mcp_config(self) -> McpConfig:
         """Load mcp.json configuration."""
@@ -136,10 +111,14 @@ async def new_runtime(
             runtime_id=runtime_id,
             entrypoint=entrypoint,
             folder_key=self.context.folder_key,
-            server_id=self._server_id,
-            server_slug=self._server_slug,
+            server_id=self.context.mcp_server_id,
+            server_slug=self.context.mcp_server_slug,
         )
 
+    async def get_settings(self) -> UiPathRuntimeFactorySettings | None:
+        """Get factory settings."""
+        return None
+
     async def dispose(self) -> None:
         """Cleanup factory resources."""
         self._mcp_config = None

src/uipath_mcp/_cli/_runtime/_runtime.py

@@ -12,8 +12,6 @@
 from mcp import ClientSession, StdioServerParameters, stdio_client
 from mcp.types import JSONRPCResponse, ListToolsResult
 from opentelemetry import trace
-from opentelemetry.sdk.trace import TracerProvider
-from opentelemetry.sdk.trace.export import BatchSpanProcessor
 from pysignalr.client import SignalRClient
 from pysignalr.messages import CompletionMessage
 from uipath.platform import UiPath
@@ -30,7 +28,6 @@
     UiPathErrorCode,
 )
 from uipath.runtime.events import UiPathRuntimeStateEvent
-from uipath.tracing import LlmOpsHttpExporter
 
 from .._utils._config import McpServer
 from ._context import UiPathServerType
@@ -79,7 +76,6 @@ def __init__(
         self._cancel_event = asyncio.Event()
         self._keep_alive_task: Optional[asyncio.Task[None]] = None
         self._uipath = UiPath()
-        self._trace_provider: Optional[TracerProvider] = None
 
         # Context fields accessed from environment
         self._job_id = os.environ.get("UIPATH_JOB_KEY")
@@ -89,7 +85,6 @@ def __init__(
 
     def _validate_auth(self) -> None:
         """Validate authentication-related configuration.
-        TODO: do we still need this?
 
         Raises:
             UiPathMcpRuntimeError: If any required authentication values are missing.
@@ -236,13 +231,6 @@ async def emit_state(node_name: str, payload: dict[str, Any]) -> None:
                 await event_queue.put(event)
 
         try:
-            if self._job_id:
-                self._trace_provider = TracerProvider()
-                trace.set_tracer_provider(self._trace_provider)
-                self._trace_provider.add_span_processor(
-                    BatchSpanProcessor(LlmOpsHttpExporter())
-                )
-
             await emit_state("initializing", {"status": "validating_auth"})
 
             # Validate authentication configuration
@@ -371,8 +359,6 @@ async def emit_state(node_name: str, payload: dict[str, Any]) -> None:
             ) from e
         finally:
             await self._cleanup()
-            if self._trace_provider:
-                self._trace_provider.shutdown()
 
     async def dispose(self) -> None:
         """Cleanup runtime resources."""
@@ -705,7 +691,7 @@ async def _on_runtime_abort(self) -> None:
             response = await self._uipath.api_client.request_async(
                 "POST",
                 f"agenthub_/mcp/{self.slug}/runtime/abort?runtimeId={self._runtime_id}",
-                headers={"X-UIPATH-FolderKey": self.context.folder_key},
+                headers={"X-UIPATH-FolderKey": self._folder_key},
             )
             if response.status_code == 202:
                 logger.info(