|
| 1 | +"""Tests for resource overwrites context ordering in the eval CLI. |
| 2 | +
|
| 3 | +The overwrites context must be entered before the runtime is created: |
| 4 | +building the agent graph resolves folder-scoped resources (e.g. escalation |
| 5 | +memory spaces) at tool-creation time, and those lookups need the |
| 6 | +overwritten folder paths. |
| 7 | +""" |
| 8 | + |
| 9 | +import json |
| 10 | +import os |
| 11 | +from contextlib import ExitStack |
| 12 | +from typing import Any |
| 13 | +from unittest.mock import AsyncMock, Mock, patch |
| 14 | + |
| 15 | +import pytest |
| 16 | +from click.testing import CliRunner |
| 17 | + |
| 18 | +from uipath._cli import cli |
| 19 | +from uipath._cli.middlewares import MiddlewareResult |
| 20 | +from uipath.platform.common._bindings import _resource_overwrites |
| 21 | + |
| 22 | + |
| 23 | +def _middleware_continue() -> MiddlewareResult: |
| 24 | + return MiddlewareResult( |
| 25 | + should_continue=True, |
| 26 | + error_message=None, |
| 27 | + should_include_stacktrace=False, |
| 28 | + ) |
| 29 | + |
| 30 | + |
| 31 | +def _write_project_files() -> None: |
| 32 | + with open("uipath.json", "w") as f: |
| 33 | + json.dump({"functions": {"agent": "main.py:main"}}, f) |
| 34 | + |
| 35 | + os.makedirs("evaluations/eval-sets", exist_ok=True) |
| 36 | + eval_set = { |
| 37 | + "version": "1.0", |
| 38 | + "id": "test-set", |
| 39 | + "name": "Test Set", |
| 40 | + "evaluatorRefs": [], |
| 41 | + "evaluations": [], |
| 42 | + } |
| 43 | + with open("evaluations/eval-sets/test-set.json", "w") as f: |
| 44 | + json.dump(eval_set, f) |
| 45 | + |
| 46 | + |
| 47 | +def _make_mock_runtime() -> Mock: |
| 48 | + mock_runtime = Mock() |
| 49 | + mock_runtime.get_schema = AsyncMock( |
| 50 | + return_value=Mock(metadata=None, input_schema=None, output_schema=None) |
| 51 | + ) |
| 52 | + mock_runtime.dispose = AsyncMock() |
| 53 | + return mock_runtime |
| 54 | + |
| 55 | + |
| 56 | +def _make_mock_factory(mock_runtime: Mock) -> Mock: |
| 57 | + mock_factory = Mock() |
| 58 | + mock_factory.discover_entrypoints.return_value = ["agent"] |
| 59 | + mock_factory.get_settings = AsyncMock(return_value=None) |
| 60 | + mock_factory.dispose = AsyncMock() |
| 61 | + mock_factory.new_runtime = AsyncMock(return_value=mock_runtime) |
| 62 | + return mock_factory |
| 63 | + |
| 64 | + |
| 65 | +def _enter_base_patches(stack: ExitStack, mock_factory: Mock) -> None: |
| 66 | + stack.enter_context( |
| 67 | + patch( |
| 68 | + "uipath._cli.cli_eval.Middlewares.next", |
| 69 | + return_value=_middleware_continue(), |
| 70 | + ) |
| 71 | + ) |
| 72 | + stack.enter_context( |
| 73 | + patch( |
| 74 | + "uipath._cli.cli_eval.UiPathRuntimeFactoryRegistry.get", |
| 75 | + return_value=mock_factory, |
| 76 | + ) |
| 77 | + ) |
| 78 | + stack.enter_context( |
| 79 | + patch("uipath._cli.cli_eval.setup_reporting_prereq", return_value=False) |
| 80 | + ) |
| 81 | + stack.enter_context( |
| 82 | + patch( |
| 83 | + "uipath._cli.cli_eval.EvalHelpers.load_evaluators", |
| 84 | + new=AsyncMock(return_value=[]), |
| 85 | + ) |
| 86 | + ) |
| 87 | + stack.enter_context( |
| 88 | + patch("uipath._cli.cli_eval.evaluate", new=AsyncMock(return_value=None)) |
| 89 | + ) |
| 90 | + |
| 91 | + |
| 92 | +class TestEvalResourceOverwritesOrdering: |
| 93 | + def test_overwrites_context_active_when_runtime_is_created( |
| 94 | + self, runner: CliRunner, temp_dir: str, monkeypatch: pytest.MonkeyPatch |
| 95 | + ) -> None: |
| 96 | + """new_runtime must run inside the resource overwrites context.""" |
| 97 | + monkeypatch.setenv("UIPATH_PROJECT_ID", "project-123") |
| 98 | + |
| 99 | + with runner.isolated_filesystem(temp_dir=temp_dir): |
| 100 | + _write_project_files() |
| 101 | + |
| 102 | + overwrite = Mock() |
| 103 | + overwrites = {"memorySpace.MemorySpace": overwrite} |
| 104 | + overwrites_seen_by_new_runtime: list[Any] = [] |
| 105 | + |
| 106 | + mock_runtime = _make_mock_runtime() |
| 107 | + |
| 108 | + async def new_runtime(*args: Any, **kwargs: Any) -> Mock: |
| 109 | + overwrites_seen_by_new_runtime.append(_resource_overwrites.get()) |
| 110 | + return mock_runtime |
| 111 | + |
| 112 | + mock_factory = _make_mock_factory(mock_runtime) |
| 113 | + mock_factory.new_runtime = AsyncMock(side_effect=new_runtime) |
| 114 | + |
| 115 | + mock_studio_client = Mock() |
| 116 | + mock_studio_client.get_resource_overwrites = AsyncMock( |
| 117 | + return_value=overwrites |
| 118 | + ) |
| 119 | + |
| 120 | + with ExitStack() as stack: |
| 121 | + _enter_base_patches(stack, mock_factory) |
| 122 | + stack.enter_context( |
| 123 | + patch( |
| 124 | + "uipath._cli.cli_eval.StudioClient", |
| 125 | + return_value=mock_studio_client, |
| 126 | + ) |
| 127 | + ) |
| 128 | + result = runner.invoke(cli, ["eval"]) |
| 129 | + |
| 130 | + assert result.exit_code == 0 |
| 131 | + mock_studio_client.get_resource_overwrites.assert_awaited_once() |
| 132 | + assert overwrites_seen_by_new_runtime == [overwrites] |
| 133 | + mock_runtime.dispose.assert_awaited_once() |
| 134 | + |
| 135 | + def test_no_project_id_runs_without_overwrites( |
| 136 | + self, runner: CliRunner, temp_dir: str, monkeypatch: pytest.MonkeyPatch |
| 137 | + ) -> None: |
| 138 | + monkeypatch.delenv("UIPATH_PROJECT_ID", raising=False) |
| 139 | + |
| 140 | + with runner.isolated_filesystem(temp_dir=temp_dir): |
| 141 | + _write_project_files() |
| 142 | + |
| 143 | + overwrites_seen_by_new_runtime: list[Any] = [] |
| 144 | + mock_runtime = _make_mock_runtime() |
| 145 | + |
| 146 | + async def new_runtime(*args: Any, **kwargs: Any) -> Mock: |
| 147 | + overwrites_seen_by_new_runtime.append(_resource_overwrites.get()) |
| 148 | + return mock_runtime |
| 149 | + |
| 150 | + mock_factory = _make_mock_factory(mock_runtime) |
| 151 | + mock_factory.new_runtime = AsyncMock(side_effect=new_runtime) |
| 152 | + |
| 153 | + with ExitStack() as stack: |
| 154 | + _enter_base_patches(stack, mock_factory) |
| 155 | + mock_studio_client_cls = stack.enter_context( |
| 156 | + patch("uipath._cli.cli_eval.StudioClient") |
| 157 | + ) |
| 158 | + result = runner.invoke(cli, ["eval"]) |
| 159 | + |
| 160 | + assert result.exit_code == 0 |
| 161 | + mock_studio_client_cls.assert_not_called() |
| 162 | + assert overwrites_seen_by_new_runtime == [None] |
| 163 | + mock_runtime.dispose.assert_awaited_once() |
| 164 | + |
| 165 | + def test_runtime_disposed_when_schema_loading_fails( |
| 166 | + self, runner: CliRunner, temp_dir: str, monkeypatch: pytest.MonkeyPatch |
| 167 | + ) -> None: |
| 168 | + monkeypatch.delenv("UIPATH_PROJECT_ID", raising=False) |
| 169 | + |
| 170 | + with runner.isolated_filesystem(temp_dir=temp_dir): |
| 171 | + _write_project_files() |
| 172 | + |
| 173 | + mock_runtime = _make_mock_runtime() |
| 174 | + mock_runtime.get_schema = AsyncMock( |
| 175 | + side_effect=RuntimeError("schema loading failed") |
| 176 | + ) |
| 177 | + mock_factory = _make_mock_factory(mock_runtime) |
| 178 | + |
| 179 | + with ExitStack() as stack: |
| 180 | + _enter_base_patches(stack, mock_factory) |
| 181 | + stack.enter_context(patch("uipath._cli.cli_eval.StudioClient")) |
| 182 | + result = runner.invoke(cli, ["eval"]) |
| 183 | + |
| 184 | + assert result.exit_code != 0 |
| 185 | + mock_runtime.dispose.assert_awaited_once() |
0 commit comments