-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add is_case_manager field in agent declaration #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3283,6 +3283,119 @@ def test_is_conversational_false_by_default(self): | |
| assert config.is_conversational is False | ||
|
|
||
|
|
||
| class TestAgentDefinitionIsCaseManager: | ||
| """Tests for AgentDefinition.is_case_manager property.""" | ||
|
|
||
| def test_is_case_manager_true_when_metadata_set(self): | ||
| """Returns True when metadata.is_case_manager is True.""" | ||
| json_data = { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: could extract a helper for this and reduce duplication |
||
| "id": "test-case-manager", | ||
| "name": "Case Manager Agent", | ||
| "version": "1.0.0", | ||
| "metadata": { | ||
| "isConversational": False, | ||
| "isCaseManager": True, | ||
| "storageVersion": "1.0.0", | ||
| }, | ||
| "settings": { | ||
| "model": "gpt-4o", | ||
| "maxTokens": 4096, | ||
| "temperature": 0, | ||
| "engine": "basic-v1", | ||
| }, | ||
| "inputSchema": {"type": "object", "properties": {}}, | ||
| "outputSchema": {"type": "object", "properties": {}}, | ||
| "resources": [], | ||
| "messages": [ | ||
| {"role": "system", "content": "You are a case manager agent."} | ||
| ], | ||
| } | ||
|
|
||
| config: AgentDefinition = TypeAdapter(AgentDefinition).validate_python( | ||
| json_data | ||
| ) | ||
|
|
||
| assert config.is_case_manager is True | ||
|
|
||
| def test_is_case_manager_false_when_metadata_set_false(self): | ||
| """Returns False when metadata.is_case_manager is False.""" | ||
| json_data = { | ||
| "id": "test-non-case-manager", | ||
| "name": "Regular Agent", | ||
| "version": "1.0.0", | ||
| "metadata": { | ||
| "isConversational": False, | ||
| "isCaseManager": False, | ||
| "storageVersion": "1.0.0", | ||
| }, | ||
| "settings": { | ||
| "model": "gpt-4o", | ||
| "maxTokens": 4096, | ||
| "temperature": 0, | ||
| "engine": "basic-v1", | ||
| }, | ||
| "inputSchema": {"type": "object", "properties": {}}, | ||
| "outputSchema": {"type": "object", "properties": {}}, | ||
| "resources": [], | ||
| "messages": [{"role": "system", "content": "You are an agent."}], | ||
| } | ||
|
|
||
| config: AgentDefinition = TypeAdapter(AgentDefinition).validate_python( | ||
| json_data | ||
| ) | ||
|
|
||
| assert config.is_case_manager is False | ||
|
|
||
| def test_is_case_manager_false_when_not_in_metadata(self): | ||
| """Returns False when isCaseManager is not present in metadata.""" | ||
| json_data = { | ||
| "id": "test-no-case-manager-field", | ||
| "name": "Agent Without CM Field", | ||
| "version": "1.0.0", | ||
| "metadata": {"isConversational": False, "storageVersion": "1.0.0"}, | ||
| "settings": { | ||
| "model": "gpt-4o", | ||
| "maxTokens": 4096, | ||
| "temperature": 0, | ||
| "engine": "basic-v1", | ||
| }, | ||
| "inputSchema": {"type": "object", "properties": {}}, | ||
| "outputSchema": {"type": "object", "properties": {}}, | ||
| "resources": [], | ||
| "messages": [{"role": "system", "content": "You are an agent."}], | ||
| } | ||
|
|
||
| config: AgentDefinition = TypeAdapter(AgentDefinition).validate_python( | ||
| json_data | ||
| ) | ||
|
|
||
| assert config.is_case_manager is False | ||
|
|
||
| def test_is_case_manager_false_when_no_metadata(self): | ||
| """Returns False when agent has no metadata.""" | ||
| json_data = { | ||
| "id": "test-no-metadata", | ||
| "name": "Agent Without Metadata", | ||
| "version": "1.0.0", | ||
| "settings": { | ||
| "model": "gpt-4o", | ||
| "maxTokens": 4096, | ||
| "temperature": 0, | ||
| "engine": "basic-v1", | ||
| }, | ||
| "inputSchema": {"type": "object", "properties": {}}, | ||
| "outputSchema": {"type": "object", "properties": {}}, | ||
| "resources": [], | ||
| "messages": [{"role": "system", "content": "You are an agent."}], | ||
| } | ||
|
|
||
| config: AgentDefinition = TypeAdapter(AgentDefinition).validate_python( | ||
| json_data | ||
| ) | ||
|
|
||
| assert config.is_case_manager is False | ||
|
|
||
|
|
||
| class TestAgentBuilderConfigResources: | ||
| """Tests for AgentDefinition resource configuration parsing.""" | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think this is redundant, if metadata is present then it should always have
is_case_managersince it's not an optional field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in frontend it is an optional field.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but in the model it has a default. so only
metadataneeds to be checked