fix: address claude comments

Author: ninja-shreyash

src/models/orchestrator/jobs.models.ts

@@ -1,8 +1,8 @@
 import { JobGetAllOptions, JobGetByIdOptions, RawJobGetResponse } from './jobs.types';
 import { PaginatedResponse, NonPaginatedResponse, HasPaginationOptions } from '../../utils/pagination';
 
-// Combined type for job data with methods
-export type JobGetResponse = RawJobGetResponse & JobMethods;
+/** Combined response type for job data with bound methods. */
+export interface JobGetResponse extends RawJobGetResponse, JobMethods {}
 
 /**
  * Service for managing UiPath Orchestrator Jobs.

tests/integration/shared/orchestrator/jobs.integration.test.ts

@@ -63,7 +63,7 @@ describe.each(modes)('Orchestrator Jobs - Integration Tests [%s]', (mode) => {
   });
 
   describe('getById', () => {
-    it('should retrieve a job by key', async () => {
+    it('should retrieve a fully transformed job with bound methods', async () => {
       const { jobs, folderId } = getJobsService();
 
       if (!folderId) {
@@ -77,17 +77,33 @@ describe.each(modes)('Orchestrator Jobs - Integration Tests [%s]', (mode) => {
       });
 
       if (allJobs.items.length === 0) {
-        throw new Error('No jobs available to test getById.');
+        console.warn('No jobs available to test getById — skipping.');
+        return;
       }
 
       const jobKey = allJobs.items[0].key;
       const job = await jobs.getById(jobKey, folderId);
 
+      // Core fields
       expect(job).toBeDefined();
       expect(job.id).toBeDefined();
       expect(job.key).toBe(jobKey);
       expect(job.state).toBeDefined();
       expect(typeof job.id).toBe('number');
+
+      // Bound methods
+      expect(job.getOutput).toBeDefined();
+      expect(typeof job.getOutput).toBe('function');
+
+      // Verify transformed camelCase fields exist
+      expect(job.createdTime).toBeDefined();
+      expect(job.processName).toBeDefined();
+      expect(job.folderId).toBeDefined();
+
+      // Verify original PascalCase API fields are absent
+      expect((job as any).CreationTime).toBeUndefined();
+      expect((job as any).ReleaseName).toBeUndefined();
+      expect((job as any).OrganizationUnitId).toBeUndefined();
     });
 
     it('should retrieve a job with expand options', async () => {
@@ -103,7 +119,8 @@ describe.each(modes)('Orchestrator Jobs - Integration Tests [%s]', (mode) => {
       });
 
       if (allJobs.items.length === 0) {
-        throw new Error('No jobs available to test getById with expand.');
+        console.warn('No jobs available to test getById with expand — skipping.');
+        return;
       }
 
       const jobKey = allJobs.items[0].key;
@@ -114,59 +131,6 @@ describe.each(modes)('Orchestrator Jobs - Integration Tests [%s]', (mode) => {
       expect(job).toBeDefined();
       expect(job.key).toBe(jobKey);
     });
-
-    it('should have bound getOutput method on result', async () => {
-      const { jobs, folderId } = getJobsService();
-
-      if (!folderId) {
-        throw new Error('INTEGRATION_TEST_FOLDER_ID is required for getById tests.');
-      }
-
-      const allJobs = await jobs.getAll({
-        folderId,
-        pageSize: 1,
-      });
-
-      if (allJobs.items.length === 0) {
-        throw new Error('No jobs available to test getById bound methods.');
-      }
-
-      const jobKey = allJobs.items[0].key;
-      const job = await jobs.getById(jobKey, folderId);
-
-      expect(job.getOutput).toBeDefined();
-      expect(typeof job.getOutput).toBe('function');
-    });
-
-    it('should have transformed camelCase fields and no PascalCase fields', async () => {
-      const { jobs, folderId } = getJobsService();
-
-      if (!folderId) {
-        throw new Error('INTEGRATION_TEST_FOLDER_ID is required for getById transform tests.');
-      }
-
-      const allJobs = await jobs.getAll({
-        folderId,
-        pageSize: 1,
-      });
-
-      if (allJobs.items.length === 0) {
-        throw new Error('No jobs available to validate transform.');
-      }
-
-      const jobKey = allJobs.items[0].key;
-      const job = await jobs.getById(jobKey, folderId);
-
-      // Verify transformed camelCase fields exist
-      expect(job.createdTime).toBeDefined();
-      expect(job.processName).toBeDefined();
-      expect(job.folderId).toBeDefined();
-
-      // Verify original PascalCase API fields are absent
-      expect((job as any).CreationTime).toBeUndefined();
-      expect((job as any).ReleaseName).toBeUndefined();
-      expect((job as any).OrganizationUnitId).toBeUndefined();
-    });
   });
 
   describe('getOutput', () => {
@@ -185,7 +149,8 @@ describe.each(modes)('Orchestrator Jobs - Integration Tests [%s]', (mode) => {
       });
 
       if (result.items.length === 0) {
-        throw new Error('No successful jobs found to test getOutput.');
+        console.warn('No successful jobs found to test getOutput — skipping.');
+        return;
       }
 
       const job = result.items[0];
@@ -208,7 +173,8 @@ describe.each(modes)('Orchestrator Jobs - Integration Tests [%s]', (mode) => {
       });
 
       if (result.items.length === 0) {
-        throw new Error('No jobs available to validate structure');
+        console.warn('No jobs available to validate structure — skipping.');
+        return;
       }
 
       const job = result.items[0];