fix(integration): move upload attachment to beforeAll in download tests

Author: Sarath1018

tests/integration/shared/data-fabric/attachment.integration.test.ts

@@ -1,6 +1,6 @@
-import { describe, it, expect } from 'vitest';
+import { beforeAll, describe, it, expect } from 'vitest';
 import { setupUnifiedTests, getServices, InitMode } from '../../config/unified-setup';
-import { retryWithBackoff } from '../../utils/helpers';
+import { wait } from '../../utils/helpers';
 
 /**
  * Integration tests for entity attachment operations (upload, remove)
@@ -69,11 +69,11 @@ describe.skipIf(!hasAttachmentConfig).each(modes)(
     });
 
     describe('deleteAttachment', () => {
-      it('should upload and then delete an attachment via service method', async () => {
+      beforeAll(async () => {
         const { entities } = getServices();
 
-        // First upload an attachment so there's something to delete
-        const fileContent = 'Temporary file for delete attachment test';
+        // Upload once so both delete tests run against an already-propagated attachment
+        const fileContent = 'Temporary file for delete attachment tests';
         const file = new Blob([fileContent], { type: 'text/plain' });
 
         await entities.uploadAttachment(
@@ -83,7 +83,13 @@ describe.skipIf(!hasAttachmentConfig).each(modes)(
           file,
         );
 
-        // Now delete the attachment
+        // Allow time for the API to propagate the upload before delete tests run
+        await wait(2000);
+      });
+
+      it('should delete an attachment via service method', async () => {
+        const { entities } = getServices();
+
         const result = await entities.deleteAttachment(
           ATTACHMENT_CONFIG.entityId,
           ATTACHMENT_CONFIG.recordId,
@@ -93,22 +99,11 @@ describe.skipIf(!hasAttachmentConfig).each(modes)(
         expect(result).toBeDefined();
       });
 
-      it('should upload and then delete an attachment via entity method', async () => {
+      it('should delete an attachment via entity method', async () => {
         const { entities } = getServices();
 
         const entity = await entities.getById(ATTACHMENT_CONFIG.entityId);
 
-        // First upload an attachment so there's something to delete
-        const fileContent = 'Temporary file for entity method delete test';
-        const file = new Blob([fileContent], { type: 'text/plain' });
-
-        await entity.uploadAttachment(
-          ATTACHMENT_CONFIG.recordId,
-          ATTACHMENT_CONFIG.fieldName,
-          file,
-        );
-
-        // Now delete the attachment
         const result = await entity.deleteAttachment(
           ATTACHMENT_CONFIG.recordId,
           ATTACHMENT_CONFIG.fieldName,
@@ -119,11 +114,11 @@ describe.skipIf(!hasAttachmentConfig).each(modes)(
     });
 
     describe('downloadAttachment', () => {
-      it('should upload and then download an attachment via service method', async () => {
+      beforeAll(async () => {
         const { entities } = getServices();
 
-        // First upload an attachment so there's something to download
-        const fileContent = 'Temporary file for download attachment test';
+        // Upload once so both download tests run against an already-propagated attachment
+        const fileContent = 'Temporary file for download attachment tests';
         const file = new Blob([fileContent], { type: 'text/plain' });
 
         await entities.uploadAttachment(
@@ -133,7 +128,13 @@ describe.skipIf(!hasAttachmentConfig).each(modes)(
           file,
         );
 
-        // Now download the attachment
+        // Allow time for the API to propagate the upload before download tests run
+        await wait(2000);
+      });
+
+      it('should download an attachment via service method', async () => {
+        const { entities } = getServices();
+
         const downloadedFile = await entities.downloadAttachment(
           ATTACHMENT_CONFIG.entityId,
           ATTACHMENT_CONFIG.recordId,
@@ -143,27 +144,14 @@ describe.skipIf(!hasAttachmentConfig).each(modes)(
         expect(downloadedFile).toBeDefined();
       });
 
-      it('should upload and then download an attachment via entity method', async () => {
+      it('should download an attachment via entity method', async () => {
         const { entities } = getServices();
 
         const entity = await entities.getById(ATTACHMENT_CONFIG.entityId);
 
-        // First upload an attachment so there's something to download
-        const fileContent = 'Temporary file for entity method download test';
-        const file = new Blob([fileContent], { type: 'text/plain' });
-
-        await entity.uploadAttachment(
+        const downloadedFile = await entity.downloadAttachment(
           ATTACHMENT_CONFIG.recordId,
           ATTACHMENT_CONFIG.fieldName,
-          file,
-        );
-
-        // Retry download to handle API propagation delay after upload
-        const downloadedFile = await retryWithBackoff(() =>
-          entity.downloadAttachment(
-            ATTACHMENT_CONFIG.recordId,
-            ATTACHMENT_CONFIG.fieldName,
-          )
         );
 
         expect(downloadedFile).toBeDefined();