Commit c129794
feat(conversations): expose disconnect method for clean process exit (#340)
The SessionManager already has a disconnect() method but it was not
exposed through the public ConversationService API. CLI consumers that
use startSession/endSession had no way to close the underlying WebSocket,
causing the process to hang indefinitely due to socket.io reconnection
timers keeping the event loop alive.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 97d17a7 commit c129794
3 files changed
Lines changed: 40 additions & 0 deletions
File tree
- src
- models/conversational-agent/conversations
- services/conversational-agent/conversations
- tests/unit/services/conversational-agent
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
367 | 381 | | |
368 | 382 | | |
369 | 383 | | |
| |||
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
471 | 471 | | |
472 | 472 | | |
473 | 473 | | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
474 | 491 | | |
475 | 492 | | |
476 | 493 | | |
| |||
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| |||
651 | 652 | | |
652 | 653 | | |
653 | 654 | | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
654 | 663 | | |
655 | 664 | | |
0 commit comments