|
1 | | -import { describe, it, expect, beforeEach } from 'vitest'; |
| 1 | +import { describe, it, expect, beforeEach, beforeAll } from 'vitest'; |
2 | 2 | import { getServices, setupUnifiedTests, InitMode } from '../../config/unified-setup'; |
3 | 3 | import { Feedback } from '../../../../src/services/agents/feedback'; |
4 | | -import { FeedbackStatus } from '../../../../src/models/agents/feedback/feedback.types'; |
| 4 | +import { FeedbackStatus, FeedbackGetResponse } from '../../../../src/models/agents/feedback/feedback.types'; |
5 | 5 |
|
6 | 6 | const modes: InitMode[] = ['v1']; |
7 | 7 |
|
@@ -61,4 +61,51 @@ describe.each(modes)('Agent Feedback - Integration Tests [%s]', (mode) => { |
61 | 61 | expect(item.updatedTime).toBeDefined(); |
62 | 62 | }); |
63 | 63 | }); |
| 64 | + |
| 65 | + describe('getById', () => { |
| 66 | + let existingFeedbackId!: string; |
| 67 | + let existingFolderKey!: string; |
| 68 | + |
| 69 | + beforeAll(async () => { |
| 70 | + feedback = getServices().feedback!; |
| 71 | + const result = await feedback.getAll({ pageSize: 1 }); |
| 72 | + if (result.items.length === 0) { |
| 73 | + throw new Error('No feedback available for getById tests — create at least one feedback entry first'); |
| 74 | + } |
| 75 | + existingFeedbackId = result.items[0].id; |
| 76 | + if (!result.items[0].folderKey) { |
| 77 | + throw new Error('Feedback entry missing folderKey — cannot run getById tests'); |
| 78 | + } |
| 79 | + existingFolderKey = result.items[0].folderKey; |
| 80 | + }); |
| 81 | + |
| 82 | + it('should retrieve feedback by ID', async () => { |
| 83 | + const result = await feedback.getById(existingFeedbackId, { folderKey: existingFolderKey }); |
| 84 | + |
| 85 | + expect(result).toBeDefined(); |
| 86 | + expect(result.id).toBe(existingFeedbackId); |
| 87 | + }); |
| 88 | + |
| 89 | + it('should have expected fields on the retrieved feedback', async () => { |
| 90 | + const result: FeedbackGetResponse = await feedback.getById(existingFeedbackId, { folderKey: existingFolderKey }); |
| 91 | + |
| 92 | + expect(result.id).toBeDefined(); |
| 93 | + expect(result.traceId).toBeDefined(); |
| 94 | + expect(result.spanId).toBeDefined(); |
| 95 | + expect(typeof result.isPositive).toBe('boolean'); |
| 96 | + expect(Array.isArray(result.feedbackCategories)).toBe(true); |
| 97 | + expect(result.status).toBeDefined(); |
| 98 | + expect(result.createdTime).toBeDefined(); |
| 99 | + expect(result.updatedTime).toBeDefined(); |
| 100 | + }); |
| 101 | + |
| 102 | + it('should transform API fields — camelCase fields present, raw fields absent', async () => { |
| 103 | + const result = await feedback.getById(existingFeedbackId, { folderKey: existingFolderKey }); |
| 104 | + |
| 105 | + expect(result.createdTime).toBeDefined(); |
| 106 | + expect(result.updatedTime).toBeDefined(); |
| 107 | + expect((result as any).createdAt).toBeUndefined(); |
| 108 | + expect((result as any).updatedAt).toBeUndefined(); |
| 109 | + }); |
| 110 | + }); |
64 | 111 | }); |
0 commit comments