feat(subscriptions): publisher/group-level updates (PR 6/7)#518
Open
sarthak688 wants to merge 7 commits into
Open
feat(subscriptions): publisher/group-level updates (PR 6/7)#518sarthak688 wants to merge 7 commits into
sarthak688 wants to merge 7 commits into
Conversation
Establishes the notification service module with the inbox listing
endpoint. Routes at the organization level via NOTIFICATION_BASE
(URL-traversal trick to bypass the tenant segment). tenantId is taken
as a positional argument and forwarded via X-UIPATH-Internal-TenantId.
Foundation included for follow-up PRs that add the remaining inbox and
subscription methods on top of this branch:
- @uipath/uipath-typescript/notifications subpath in package.json + rollup
- NOTIFICATION_BASE, NOTIFICATION_ENDPOINTS scaffold
- test infra (NOTIFICATION_TEST_TENANT_ID env var, test-config,
unified-setup registration, notification mock factories, constants)
- oauth-scopes + pagination + mkdocs nav entries
Methods: getAll (paginated OData listing with $top/$skip/$count,
filter, orderby; transformFn drops 8 internal/transport fields).
Tests: 4 unit + 4 integration (skipped when NOTIFICATION_TEST_TENANT_ID
is not set).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…llRead) Adds the three read-state mutation methods on top of the foundation established in feat/notifications-sdk. All three POST to the NotificationEntry.UpdateRead OData action; markAllRead uses the server-side forceAllRead flag. Adds UPDATE_READ endpoint constant and per-method telemetry decorators. Tests: 6 additional unit tests + 2 integration tests (mark/unmark round-trip + markAllRead). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds the two delete methods. Both POST to the NotificationEntry.DeleteBulk OData action; deleteAll uses the server-side deleteAll flag. Preserves the API spec's misspelling `notifcationIds` in the request body — the server expects that exact (mistyped) key. Tests: 4 additional unit tests. No integration tests — these destructively mutate the inbox with no SDK-level undo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds the SubscriptionService class alongside the existing NotificationService. Both services live under @uipath/uipath-typescript/notifications as discrete classes (no shared state). Subscription endpoints route through the same notificationservice_ base via the URL-traversal trick. Methods: getAll, getPublishers, getSupportedChannels — the three read-side methods that return user subscription state and tenant channel availability. Mutation methods land in follow-up PRs. Adds SUBSCRIPTION_ENDPOINTS scaffold (3 read URLs), subscription model types (SubscriptionPublisher, SubscriptionTopic, SubscriptionMode, SupportedChannel, AllowedMode, options types), subscription test infrastructure (mock factories), Subscriptions section in oauth-scopes and mkdocs nav, and Subscriptions registration in unified-setup. Tests: 8 unit + 4 integration. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…gory) Adds the two topic/category-scoped subscription writes. Each entry in the payload sets the subscription state for a single (topic, mode) or (category, mode) pair. UPDATE_TOPIC reuses the same URL as GET_ALL — POST vs GET differentiates. Adds TopicSubscriptionUpdate and CategorySubscriptionUpdate types, response types, oauth-scopes entries, and unit + integration tests (updateTopic round-trip; updateCategory unit-only because it needs richer tenant fixtures). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…er, updateTopicGroup) Adds the two broader-scope subscription writes: - updatePublisher: opt-in/out at the publisher level, optionally scoped to specific entities (folders, etc.) - updateTopicGroup: scope a named topic group to a set of entities API spec misspells the publisher key as `publisherID`; the SDK preserves the typo at send time and keeps the public surface clean (`publisherId`). Adds PublisherSubscriptionUpdate + TopicGroupSubscriptionUpdate types, response types, oauth-scopes entries, 5 new unit tests, and an updatePublisher round-trip integration test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 12, 2026
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
…uth-scopes entries Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
| * { publisherId: '<publisherId>', isUserOptIn: false }, | ||
| * ]); | ||
| * ``` | ||
| * @internal |
Contributor
There was a problem hiding this comment.
if these methods are public dont mark them as internal. Check for other similar methods as well
Contributor
|
in PR description u mentioned docs/oauth scopes have also changed but i dont see it , is that part of another dependent PR? |
| // Intentional duplicate URL of GET_ALL: same path, POST vs GET differentiates the operation. | ||
| UPDATE_TOPIC: `${SUBSCRIPTION_API_BASE}/api/v1/UserSubscription`, | ||
| UPDATE_CATEGORY: `${SUBSCRIPTION_API_BASE}/api/v1/UserSubscription/CategorySubscription`, | ||
| UPDATE_PUBLISHER: `${SUBSCRIPTION_API_BASE}/api/v1/UserSubscription/PublisherSubscription`, |
Contributor
There was a problem hiding this comment.
add js doc for remaining constants as well like u have done for UPDATE_TOPIC
sarthak688
force-pushed
the
feat/subscriptions-topic-updates
branch
from
July 20, 2026 05:03
3987cc2 to
67e4d40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 6/7 in the Notification SDK stack. Stacked on top of #517.
Adds the two broader-scope subscription writes — publisher-level opt-in/out and topic-group entity scoping.
Methods Added
subscriptions.updatePublisher()updatePublisher(tenantId: string, subscriptions: PublisherSubscriptionUpdate[]): Promise<SubscriptionUpdatePublisherResponse>subscriptions.updateTopicGroup()updateTopicGroup(tenantId: string, subscriptions: TopicGroupSubscriptionUpdate[]): Promise<SubscriptionUpdateTopicGroupResponse>Endpoints Called
updatePublisher()notificationservice_/usersubscriptionservice/api/v1/UserSubscription/PublisherSubscriptionNotificationServiceupdateTopicGroup()notificationservice_/usersubscriptionservice/api/v1/UserSubscription/TopicGroupSubscriptionNotificationServicepublisherID(sic), notpublisherId. The SDK's public surface uses the clean spelling; the rename happens at send time insideupdatePublisher.updatePublishersupports optional entity scoping (e.g. opt in for two specific folders only);updateTopicGroupalways scopes a named topic group to a list of entities.Example Usage
Verification
npm run typechecknpm run lintnpm run test:unitIntegration:
updatePublisherround-trip — flip the user's opt-in for the first visible publisher, then restore.updateTopicGroupis unit-only because it needs a configured topic group on the test tenant.Files
src/utils/constants/endpoints/notification.ts(UPDATE_PUBLISHER,UPDATE_TOPIC_GROUP)src/models/notification/subscriptions.types.ts(PublisherSubscriptionUpdate,TopicGroupSubscriptionUpdate)src/models/notification/subscriptions.models.ts(response types + ServiceModel methods)src/services/notification/subscriptions.tstests/unit/services/notification/subscriptions.test.ts(+5 tests)tests/integration/shared/notification/subscriptions.integration.test.ts(+1 round-trip test)docs/oauth-scopes.mdPR Stack
feat/notifications-sdkfeat/notifications-mark-readfeat/notifications-deletefeat/subscriptions-sdkfeat/subscriptions-topic-updatesfeat/subscriptions-publisher-updates(this PR)feat/subscriptions-mode-reset🤖 Generated with Claude Code