Skip to content

fix: getExecutionHistory changes#270

Draft
vnaren23 wants to merge 3 commits into
mainfrom
users/naren/getexecutionfix
Draft

fix: getExecutionHistory changes#270
vnaren23 wants to merge 3 commits into
mainfrom
users/naren/getexecutionfix

Conversation

@vnaren23

@vnaren23 vnaren23 commented Mar 9, 2026

Copy link
Copy Markdown
Collaborator

Fixes #265

@vnaren23 vnaren23 self-assigned this Mar 9, 2026
@vnaren23 vnaren23 force-pushed the users/naren/getexecutionfix branch from 794a7f0 to 390ed98 Compare April 14, 2026 09:55
@sonarqubecloud

Copy link
Copy Markdown

Comment thread tests/unit/services/maestro/process-instances.test.ts
Comment thread tests/unit/services/maestro/process-instances.test.ts
Comment thread tests/utils/mocks/maestro.ts
Comment thread tests/utils/mocks/maestro.ts
@claude

claude Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Review findings — 4 new inline comments posted:

  1. transform-completeness assertions missing (process-instances.test.ts:242) — camelCase values are tested but original PascalCase fields are not verified absent. Violates the convention documented in agent_docs/rules.md (see assets.test.ts:94, queues.test.ts:88 for the pattern).

  2. spans-API assertion passes by coincidence (process-instances.test.ts:231) — the mock instanceId equals the input instanceId, so the test never proves the service extracts the trace ID from the element-executions response.

  3. missing JSDoc on createMockElementExecutionsResponse (maestro.ts:98) — every other factory in this file has one.

  4. missing JSDoc on createMockTraceSpan (maestro.ts:133) — same.

@vnaren23 vnaren23 added the skip-claude-review Suppress claude code review on subsequent commits label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change skip-claude-review Suppress claude code review on subsequent commits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getExecutionHistory method for maestro process Instance is returning 404

1 participant