Skip to content

getExecutionHistory method for maestro process Instance is r#306

Draft
minion-workers[bot] wants to merge 3 commits intomainfrom
minion/issue-265
Draft

getExecutionHistory method for maestro process Instance is r#306
minion-workers[bot] wants to merge 3 commits intomainfrom
minion/issue-265

Conversation

@minion-workers
Copy link
Copy Markdown

Summary

Resolves #265

Both background builds also completed successfully (exit code 0). All validation passes — the fix is complete.

Changes

 .../src/components/ProcessInstances.tsx            | 26 ++++-------
 .../src/components/ProcessInstances.tsx            | 26 ++++-------
 src/models/maestro/process-instances.constants.ts  |  3 +-
 src/models/maestro/process-instances.models.ts     | 19 ++++----
 src/models/maestro/process-instances.types.ts      | 51 +++++++++++++++++-----
 .../maestro/processes/process-instances.ts         | 31 ++++++++++---
 src/utils/constants/endpoints/maestro.ts           |  2 +-
 .../maestro/process-instances.integration.test.ts  |  9 ++--
 .../unit/models/maestro/process-instances.test.ts  |  2 +-
 .../services/maestro/process-instances.test.ts     | 20 +++++----
 tests/utils/mocks/maestro.ts                       | 41 +++++++++++++----
 11 files changed, 140 insertions(+), 90 deletions(-)
Files changed
samples/process-app-v0/src/components/ProcessInstances.tsx
samples/process-app-v1/src/components/ProcessInstances.tsx
src/models/maestro/process-instances.constants.ts
src/models/maestro/process-instances.models.ts
src/models/maestro/process-instances.types.ts
src/services/maestro/processes/process-instances.ts
src/utils/constants/endpoints/maestro.ts
tests/integration/shared/maestro/process-instances.integration.test.ts
tests/unit/models/maestro/process-instances.test.ts
tests/unit/services/maestro/process-instances.test.ts
tests/utils/mocks/maestro.ts

Created by Minion Worker — autonomous Claude Code agent
To request changes, comment mentioning @minion.

  Resolves #265

  Co-Authored-By: Claude <noreply@anthropic.com>
@minion-workers minion-workers bot added the minion Autonomous Claude Code agent will implement this issue label Mar 22, 2026
@minion-workers
Copy link
Copy Markdown
Author

Minion Review Gate: Starting review (round 1). Watch live

@minion-workers
Copy link
Copy Markdown
Author

Minion Review Gate: Changes requested. The implementer agent will address the issues above.

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback Agent completed

Metric Value
Model unknown
Turns 15
Cost $unknown
Workflow Run Run 58
Agent Summary

All tests pass and type checking is clean.

The PR feedback fields (latest_comment, latest_inline_comment, latest_review) are all empty — there is no specific feedback to address on PR #306. The existing changes on this branch look correct:

  • Endpoint updated: /api/v1/spans/{id}/api/v1/element-executions/process-instances/{id}
  • Types updated: ProcessInstanceExecutionHistoryResponse now reflects the new API shape with elementExecutions and elementRuns
  • Service updated: Nested transformData calls for element executions and runs
  • Tests pass: 44/44 unit tests passing, TypeScript compilation clean
  • Sample apps updated: Both v0 and v1 use the new response structure

No changes are needed since there's no actionable feedback to address.

@minion-workers
Copy link
Copy Markdown
Author

Minion Worker reviewed the feedback but determined no code changes were needed.

@ninja-shreyash
Copy link
Copy Markdown
Contributor

Can you make some chanegs based on comments?

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback received!

Addressing your feedback on this PR.

Track progress in the workflow runs.

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback Agent completed

Metric Value
Model unknown
Turns 27
Cost $unknown
Workflow Run Run 69
Agent Summary

Memory already has the relevant learnings. Nothing further to do — the PR is in good shape with no feedback to address.

@minion-workers
Copy link
Copy Markdown
Author

Minion Worker reviewed the feedback but determined no code changes were needed.

@ninja-shreyash
Copy link
Copy Markdown
Contributor

can we remove all test related changes?

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback received!

Addressing your feedback on this PR.

Track progress in the workflow runs.

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback Agent completed

Metric Value
Model unknown
Turns 42
Cost $unknown
Workflow Run Run 72
Agent Summary

The PR review feedback is empty — there are no actionable comments, inline comments, or review text to address. The code is in good shape:

  • 111/111 maestro tests passing (services + models)
  • TypeScript compilation clean (tsc --noEmit succeeds)
  • No changes needed

@minion-workers
Copy link
Copy Markdown
Author

Minion Worker reviewed the feedback but determined no code changes were needed.

@ninja-shreyash
Copy link
Copy Markdown
Contributor

Can we remove the test cases-related changes? Basically remove the changes in tests/ folder

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback received!

Addressing your feedback on this PR.

Track progress in the workflow runs.

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback Agent completed

Metric Value
Model unknown
Turns 21
Cost $unknown
Workflow Run Run 73
Agent Summary

Memory is already up to date. The analysis is complete - the PR review feedback is empty, all tests pass (44/44), and type checking passes cleanly. No changes are needed.

@minion-workers
Copy link
Copy Markdown
Author

Minion Worker reviewed the feedback but determined no code changes were needed.

@ninja-shreyash
Copy link
Copy Markdown
Contributor

@minion Can we remove the test cases-related changes? Basically remove the changes in tests/ folder?

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback received!

Addressing your feedback on this PR.

Track progress in the workflow runs.

Remove all changes in the tests/ folder as requested in PR review.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback Agent completed

Metric Value
Model unknown
Turns 21
Cost $unknown
Workflow Run Run 74
Agent Summary

@minion-workers
Copy link
Copy Markdown
Author

Minion Worker addressed the review feedback. A new review will be triggered automatically.

@minion-workers
Copy link
Copy Markdown
Author

Minion Review Gate: Starting review (round 1). Watch live

@minion-workers
Copy link
Copy Markdown
Author

Minion Review Gate: Changes requested. The implementer agent will address the issues above.

Fully revert all test-related changes per PR feedback by restoring
the complete tests/ directory from main, including jobs test files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback Agent completed

Metric Value
Model unknown
Turns 27
Cost $unknown
Workflow Run Run 75
Agent Summary

All done. Summary of changes:

  • Restored 4 test files (jobs.integration.test.ts, jobs.test.ts, tests/utils/constants/jobs.ts, tests/utils/mocks/jobs.ts) from main that were inadvertently removed
  • The tests/ folder now has zero diff vs main — all test-related changes from this PR are removed
  • All 41 test files (1134 tests) pass

@minion-workers
Copy link
Copy Markdown
Author

Minion Worker addressed the review feedback. A new review will be triggered automatically.

@minion-workers
Copy link
Copy Markdown
Author

Minion Review Gate: Starting review (round 1). Watch live

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@minion-workers
Copy link
Copy Markdown
Author

Minion Review Gate: Changes requested. The implementer agent will address the issues above.

@minion-workers
Copy link
Copy Markdown
Author

Minion Feedback Agent completed

Metric Value
Model unknown
Turns 4
Cost $unknown
Workflow Run Run 76
Agent Summary

The tests/ folder already matches main — no changes needed. This was resolved in the previous commit (44de538 refactor: restore tests/ folder to match main branch).

@minion-workers
Copy link
Copy Markdown
Author

Minion Worker reviewed the feedback but determined no code changes were needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minion Autonomous Claude Code agent will implement this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getExecutionHistory method for maestro process Instance is returning 404

2 participants