docs: update agent docs from PR review analysis (2026-03-31 to 2026-04-07)

[ninja-shreyash]

Summary

Weekly analysis of PR comments (2026-03-31 -> 2026-04-07).
Analyzed 20 PRs with ~100 comments. Found 5 actionable insights.

Changes

agent_docs/rules.md

• Added: Never assume enum wire format from Swagger alone — verify against live API
  Source: PR Add Feedback service [PLT-92499] #184 — @ninja-shreyash on feedback enum string vs numeric mismatch:

  "The API returns "status": "Approved" (string), but this enum uses numeric values."

• Added: Never define static lookup maps inside method bodies — use module-level constants
  Source: PR feat(tasks): added GetTaskDataById API for DU-VS #323 — @Raina451 on src/services/action-center/tasks.ts:529:

  "Move TaskTypeEndpoints out of the method body, it's a static mapping that doesn't need to be rebuilt on every call."

• Added: Never bump package.json version in feature PRs — separate version PRs
  Source: PR feat(conversations): expose disconnect method for clean process exit #340 — @swati354 on package.json:3:

  "Let's not bump up the version with this change."

• Added: Verify integration tests actually exercise new code paths
  Source: PR feat(tasks): added GetTaskDataById API for DU-VS #323 — @Raina451 on tasks.integration.test.ts:137:

  "createdTaskId is a Form task but this test calls the DocumentValidation endpoint with a Form task ID"

agent_docs/conventions.md

• Added: Barrel exports convention — use export * from instead of explicit export type re-exports
  Source: PR Add Feedback service [PLT-92499] #184 — @Raina451 on src/services/llmops/index.ts:24:

  "dont export type, use: export * from"

No changes

• CLAUDE.md, Agents.md, agent_docs/architecture.md — no relevant insights

PRs Analyzed

PR	Title	State	Comments
#327	Remove camelCase conversion in DF methods	closed	9
#344	fix: add external user id header	open	2
#320	feat(jobs): onboard getOutput method	open	30+
#184	Add Feedback service	open	40+
#323	feat(tasks): added GetTaskDataById API	closed	30+
#340	feat(conversations): expose disconnect method	open	5
#252	feat: onboarding attachments getById	open	7
#291	feat(docs): update docs with coded app deployment	open	6

---

Generated by enhance-claude-docs skill

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ninja-shreyash]

Superseded by #356 which consolidates all changes from this PR plus additional insights from the updated GraphQL-based analysis.