fix(integration): move upload attachment to beforeAll in download tests#355
Open
Sarath1018 wants to merge 1 commit intomainfrom
Open
fix(integration): move upload attachment to beforeAll in download tests#355Sarath1018 wants to merge 1 commit intomainfrom
Sarath1018 wants to merge 1 commit intomainfrom
Conversation
Sarath1018
force-pushed
the
sarath/fix-integration-test
branch
2 times, most recently
from
7fd5ccd to
da9db3a
Compare
Sarath1018
force-pushed
the
sarath/fix-integration-test
branch
from
da9db3a to
cf4eb51
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests are flaky as we are trying to download/delete the attachment immedialtely after upload because of propogation delay. Example in SS
Moved upload attachment to beforeAll and added wait for propogation delay to fix this