Skip to content

fix(integration): move upload attachment to beforeAll in download tests #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sarath1018 wants to merge 1 commit into from
Closed

fix(integration): move upload attachment to beforeAll in download tests #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 23 additions & 55 deletions tests/integration/shared/data-fabric/attachment.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { describe, it, expect } from 'vitest';
import { beforeAll, beforeEach, describe, it, expect } from 'vitest';
import { setupUnifiedTests, getServices, InitMode } from '../../config/unified-setup';
import { retryWithBackoff } from '../../utils/helpers';
import { wait } from '../../utils/helpers';

/**
* Integration tests for entity attachment operations (upload, remove)
Expand Down Expand Up @@ -68,22 +68,24 @@
});
});

describe('deleteAttachment', () => {
it('should upload and then delete an attachment via service method', async () => {
const { entities } = getServices();
async function uploadAndWait(content: string): Promise<void> {

Check warning on line 71 in tests/integration/shared/data-fabric/attachment.integration.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move async function 'uploadAndWait' to the outer scope. 


See more on https://sonarcloud.io/project/issues?id=UiPath_uipath-typescript&issues=AZ1oDP3ZlzbVohSUylaM&open=AZ1oDP3ZlzbVohSUylaM&pullRequest=355
const { entities } = getServices();
const file = new Blob([content], { type: 'text/plain' });
await entities.uploadAttachment(
ATTACHMENT_CONFIG.entityId,
ATTACHMENT_CONFIG.recordId,
ATTACHMENT_CONFIG.fieldName,
file,
);
await wait(2000);
}

// First upload an attachment so there's something to delete
const fileContent = 'Temporary file for delete attachment test';
const file = new Blob([fileContent], { type: 'text/plain' });
describe('deleteAttachment', () => {
beforeEach(() => uploadAndWait('Temporary file for delete attachment tests'));

await entities.uploadAttachment(
ATTACHMENT_CONFIG.entityId,
ATTACHMENT_CONFIG.recordId,
ATTACHMENT_CONFIG.fieldName,
file,
);
it('should delete an attachment via service method', async () => {
const { entities } = getServices();

// Now delete the attachment
const result = await entities.deleteAttachment(
ATTACHMENT_CONFIG.entityId,
ATTACHMENT_CONFIG.recordId,
Expand All @@ -93,22 +95,11 @@
expect(result).toBeDefined();
});

it('should upload and then delete an attachment via entity method', async () => {
it('should delete an attachment via entity method', async () => {
const { entities } = getServices();

const entity = await entities.getById(ATTACHMENT_CONFIG.entityId);

// First upload an attachment so there's something to delete
const fileContent = 'Temporary file for entity method delete test';
const file = new Blob([fileContent], { type: 'text/plain' });

await entity.uploadAttachment(
ATTACHMENT_CONFIG.recordId,
ATTACHMENT_CONFIG.fieldName,
file,
);

// Now delete the attachment
const result = await entity.deleteAttachment(
ATTACHMENT_CONFIG.recordId,
ATTACHMENT_CONFIG.fieldName,
Expand All @@ -119,21 +110,11 @@
});

describe('downloadAttachment', () => {
it('should upload and then download an attachment via service method', async () => {
const { entities } = getServices();

// First upload an attachment so there's something to download
const fileContent = 'Temporary file for download attachment test';
const file = new Blob([fileContent], { type: 'text/plain' });
beforeAll(() => uploadAndWait('Temporary file for download attachment tests'));

await entities.uploadAttachment(
ATTACHMENT_CONFIG.entityId,
ATTACHMENT_CONFIG.recordId,
ATTACHMENT_CONFIG.fieldName,
file,
);
it('should download an attachment via service method', async () => {
const { entities } = getServices();

// Now download the attachment
const downloadedFile = await entities.downloadAttachment(
ATTACHMENT_CONFIG.entityId,
ATTACHMENT_CONFIG.recordId,
Expand All @@ -143,27 +124,14 @@
expect(downloadedFile).toBeDefined();
});

it('should upload and then download an attachment via entity method', async () => {
it('should download an attachment via entity method', async () => {
const { entities } = getServices();

const entity = await entities.getById(ATTACHMENT_CONFIG.entityId);

// First upload an attachment so there's something to download
const fileContent = 'Temporary file for entity method download test';
const file = new Blob([fileContent], { type: 'text/plain' });

await entity.uploadAttachment(
const downloadedFile = await entity.downloadAttachment(
ATTACHMENT_CONFIG.recordId,
ATTACHMENT_CONFIG.fieldName,
file,
);

// Retry download to handle API propagation delay after upload
const downloadedFile = await retryWithBackoff(() =>
entity.downloadAttachment(
ATTACHMENT_CONFIG.recordId,
ATTACHMENT_CONFIG.fieldName,
)
);

expect(downloadedFile).toBeDefined();
Expand Down
Loading