docs: update Claude docs from PR review analysis (v2)#356
Closed
ninja-shreyash wants to merge 2 commits intomainfrom
Closed
docs: update Claude docs from PR review analysis (v2)#356ninja-shreyash wants to merge 2 commits intomainfrom
ninja-shreyash wants to merge 2 commits intomainfrom
Conversation
…4-07) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…4-07) Analyzed 20 PRs with ~100 comments. Found 5 actionable insights not already covered by existing documentation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Weekly analysis of PR review threads (2026-03-31 → 2026-04-07).
Analyzed 22 PRs with 118 review threads. Found 8 actionable insights.
Method: Used GraphQL
reviewThreadsAPI to fetch resolved threads + full conversations. Classified threads as resolved/effectively-resolved/unresolved, then analyzed validity and resolution for each.Supersedes: #353 (all changes consolidated here)
Changes
agent_docs/rules.mdAdded "Static mappings" NEVER rule — static lookup tables must not be defined inside method bodies.
Source: PR feat(tasks): added GetTaskDataById API for DU-VS #323 — @Raina451: "Move TaskTypeEndpoints out of the method body, it's a static mapping that doesn't need to be rebuilt on every call."
Added "Versioning" NEVER rule — never bump
package.jsonversion in feature PRs.Source: PR feat(conversations): expose disconnect method for clean process exit #340 — @swati354: "Let's not bump up the version with this change."
Added "Enum wire format" NEVER rule — verify enum formats against live API, not just Swagger.
Source: PR Add Feedback service [PLT-92499] #184 — @swati354: "Are you saying the API returns numbers for status in the response as well?"
Added integration test code path verification rule — tests must use appropriate test data for the endpoint being tested.
Source: PR feat(tasks): added GetTaskDataById API for DU-VS #323 — @Raina451: test calling DocumentValidation endpoint with Form task ID gives false confidence.
Added CF Workers whitelist to post-implementation checklist
Source: PR feat: onboarding attachments getById for coded action apps #252 — @ninja-shreyash, PR feat(tasks): added GetTaskDataById API for DU-VS #323 — @Raina451: "ensure its whitelisted in CloudFlare worker"
agent_docs/conventions.mdAdded barrel exports convention — use
export * frominstead of redundant explicit re-exports.Source: PR Add Feedback service [PLT-92499] #184 — @swati354: "do we need to explicitly export it? Won't line 41 do this already?"
Added endpoint domain prefix collision rule — prefix with service domain when names collide.
Source: PR feat: onboarding attachments getById for coded action apps #252 — @ninja-shreyash: "can we name it ORCHESTRATOR_ATTACHMENT_ENDPOINTS?"
No changes
CLAUDE.md— no relevant insights foundAgents.md— no relevant insights foundagent_docs/architecture.md— no relevant insights foundPRs Analyzed