docs: update Claude docs from PR review analysis#404
Merged
ninja-shreyash merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
…05-04) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
ninja-shreyash
approved these changes
May 5, 2026
Raina451
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Weekly analysis of PR comments (2026-04-27 -> 2026-05-04).
Analyzed 17 PRs with comments from 10 reviewed in detail. Found 4 actionable insights.
Changes
agent_docs/rules.mdAfter a successful delete in an integration test, remove the resource from
createdRecordIdsSource: PR feat: add deleteRecordById method [PLT-95546] #338 — reviewer noted that after the delete test succeeded, the record was still in
createdRecordIds, causing a spurious failure when cleanup ran and tried to delete an already-deleted record.Consolidate service availability guards in
beforeAll, not inline per testSource: PR Add Feedback service [PLT-92499] #184 — repeated
if (!feedback) throw new Error(...)appeared in everyitblock instead of once in a sharedbeforeAll. Reviewer pushed back on the noise and duplication.When a new option is added to one method, update related methods'
@exampleblocks tooSource: PR feat(cas): agent inputs in conversations #367 —
agentInputwas added tocreate()with a new example, butupdateById()(which accepts the same option) was left without the example. Reviewer flagged it as effectively invisible to users.agent_docs/conventions.mdreturnin bound method delegates, notawaitSource: PR feat: add deleteRecordById method [PLT-95546] #338 — reviewer asked "why
awaitand not direct return?" on a bound method delegate. Theawaitwas adding an unnecessary microtask hop in factory functions that simply delegate to a service method.No changes
CLAUDE.md— no relevant insights foundAgents.md— no relevant insights foundagent_docs/architecture.md— no relevant insights foundPRs Analyzed