Use reference over copying

casperlamboo · Copilot · web-flow · commit 772390c816ea · 2026-05-04T13:12:29.000+02:00
Co-authored-by: Copilot Autofix powered by AI &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/src/eval.cpp b/src/eval.cpp
@@ -328,8 +328,8 @@ bool operator==(const CuraFormulaeEngine::eval::Value& lhs, const CuraFormulaeEn
     if (std::holds_alternative<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(lhs.value) && 
         std::holds_alternative<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(rhs.value))
     {
-        auto map_lhs = std::get<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(lhs.value);
-        auto map_rhs = std::get<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(rhs.value);
+        const auto& map_lhs = std::get<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(lhs.value);
+        const auto& map_rhs = std::get<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(rhs.value);
 
         if (map_lhs.size() != map_rhs.size())
         {

Original file line number	Diff line number	Diff line change
`@@ -328,8 +328,8 @@ bool operator==(const CuraFormulaeEngine::eval::Value& lhs, const CuraFormulaeEn`
`328`	`328`	`if (std::holds_alternative<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(lhs.value) &&`
`329`	`329`	`std::holds_alternative<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(rhs.value))`
`330`	`330`	`{`
`331`		`- auto map_lhs = std::get<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(lhs.value);`
`332`		`- auto map_rhs = std::get<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(rhs.value);`
	`331`	`+ const auto& map_lhs = std::get<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(lhs.value);`
	`332`	`+ const auto& map_rhs = std::get<std::unordered_map<std::string, CuraFormulaeEngine::eval::Value>>(rhs.value);`
`333`	`333`
`334`	`334`	`if (map_lhs.size() != map_rhs.size())`
`335`	`335`	`{`