Merge pull request #2676 from UltimateHackingKeyboard/fix-improve-agent-upgrade-message

mondalaci · web-flow · commit 1a1994a6ed2d · 2025-07-10T21:21:04.000+02:00
fix: log message of firmware contains newer user config version
diff --git a/packages/uhk-agent/src/services/device.service.ts b/packages/uhk-agent/src/services/device.service.ts
@@ -510,7 +510,7 @@ export class DeviceService {
             checkFirmwareAndDeviceCompatibility(packageJson, uhkDeviceProduct);
             if (shouldUpgradeAgent(packageJson.userConfigVersion, this.disableAgentUpgrade)) {
                 response.failReason = FirmwareUpgradeFailReason.UserConfigVersionNotSupported;
-                this.logService.error(`[DeviceService] Firmware contains newer ${packageJson.userConfigVersion} user config version than what Agent supports`);
+                this.logService.error(`[DeviceService] The firmware contains ${packageJson.userConfigVersion} user config version, which is newer than ${VERSIONS.userConfigVersion} which this Agent supports. Minor version check is used.`);
 
                 return event.sender.send(IpcEvents.device.updateFirmwareReply, response);
             }

Original file line number	Diff line number	Diff line change
`@@ -510,7 +510,7 @@ export class DeviceService {`
`510`	`510`	`checkFirmwareAndDeviceCompatibility(packageJson, uhkDeviceProduct);`
`511`	`511`	`if (shouldUpgradeAgent(packageJson.userConfigVersion, this.disableAgentUpgrade)) {`
`512`	`512`	`response.failReason = FirmwareUpgradeFailReason.UserConfigVersionNotSupported;`
`513`		- this.logService.error(`[DeviceService] Firmware contains newer ${packageJson.userConfigVersion} user config version than what Agent supports`);
	`513`	+ this.logService.error(`[DeviceService] The firmware contains ${packageJson.userConfigVersion} user config version, which is newer than ${VERSIONS.userConfigVersion} which this Agent supports. Minor version check is used.`);
`514`	`514`
`515`	`515`	`return event.sender.send(IpcEvents.device.updateFirmwareReply, response);`
`516`	`516`	`}`