feat: add always enable advanced settings Agent setting (#2972)

Expose a persisted checkbox in Settings that keeps the Advanced settings
menu visible across restarts once enabled.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Kiss Róbert <ert78gb@gmail.com>

Author: 3 people

packages/uhk-common/src/models/application-settings.ts

@@ -30,4 +30,8 @@ export interface ApplicationSettings {
      * Smart Macro panel width in percent;
      */
     smartMacroPanelWidth?: number;
+    /**
+     * If true, the Advanced settings menu is shown on Agent startup.
+     */
+    alwaysEnableAdvancedMode?: boolean;
 }

packages/uhk-web/src/app/components/agent/settings/settings.component.html

@@ -33,6 +33,17 @@ <h1>
     </div>
 </div>
 
+<div class="col-12 mt-1" *ngIf="alwaysEnableAdvancedModeSettingVisible$ | async">
+    <div class="checkbox d-inline-block mb-0 mt-0">
+        <label>
+            <input type="checkbox"
+                   [checked]="alwaysEnableAdvancedMode$ | async"
+                   (change)="toggleAlwaysEnableAdvancedMode($event.target.checked)"
+            > Always enable advanced settings
+        </label>
+    </div>
+</div>
+
 
 <div class="col-12 col-md-6 mb-0 mt-0">
     <div class="d-flex align-items-center mt-2">

packages/uhk-web/src/app/components/agent/settings/settings.component.ts

@@ -8,8 +8,10 @@ import { AppTheme, AppThemeSelect } from 'uhk-common';
 import {
     AppState,
     appUpdateSettingsState,
+    getAlwaysEnableAdvancedMode,
     getAnimationEnabled,
     getAppTheme,
+    getIsAdvancedSettingsMenuVisible,
     getOperatingSystem,
     getSupportedThemes,
     keyboardHalvesAlwaysJoined
@@ -20,6 +22,7 @@ import {
     ToggleCheckForUpdateOnStartupAction
 } from '../../../store/actions/auto-update-settings';
 import { OpenConfigFolderAction, SetAppThemeAction, ToggleAnimationEnabledAction, ToggleKeyboardHalvesAlwaysJoinedAction } from '../../../store/actions/app';
+import { ToggleAlwaysEnableAdvancedModeAction } from '../../../store/actions/advance-settings.action';
 import { OperatingSystem } from '../../../models/operating-system';
 
 @Component({
@@ -39,6 +42,8 @@ export class SettingsComponent {
     isLinux$: Observable<boolean>;
     faCog = faCog;
     keyboardHalvesAlwaysJoined$: Observable<boolean>;
+    alwaysEnableAdvancedMode$: Observable<boolean>;
+    alwaysEnableAdvancedModeSettingVisible$: Observable<boolean>;
 
     constructor(private store: Store<AppState>) {
         this.updateSettingsState$ = store.select(appUpdateSettingsState);
@@ -47,6 +52,8 @@ export class SettingsComponent {
         this.themes$ = store.select(getSupportedThemes);
         this.isLinux$ = store.select(getOperatingSystem).pipe(map(os => os === OperatingSystem.Linux));
         this.keyboardHalvesAlwaysJoined$ = store.select(keyboardHalvesAlwaysJoined);
+        this.alwaysEnableAdvancedMode$ = store.select(getAlwaysEnableAdvancedMode);
+        this.alwaysEnableAdvancedModeSettingVisible$ = store.select(getIsAdvancedSettingsMenuVisible);
     }
 
     openConfigFolder(): void {
@@ -73,4 +80,8 @@ export class SettingsComponent {
         this.store.dispatch(new ToggleKeyboardHalvesAlwaysJoinedAction(enabled));
     }
 
+    toggleAlwaysEnableAdvancedMode(enabled: boolean): void {
+        this.store.dispatch(new ToggleAlwaysEnableAdvancedModeAction(enabled));
+    }
+
 }

packages/uhk-web/src/app/store/actions/advance-settings.action.ts

@@ -19,6 +19,7 @@ export enum ActionTypes {
     toggleRightHalfZephyrLogging = '[advanceSettings] toggle right half zephyr logging',
     toggleZephyrLogging = '[advanceSettings] toggle zephyr logging',
     showAdvancedSettingsMenu = '[advanceSettings] show menu',
+    toggleAlwaysEnableAdvancedMode = '[advanceSettings] toggle always enable advanced mode',
     zephyrLog = '[advanceSettings] zephyr log',
 }
 
@@ -103,6 +104,12 @@ export class ShowAdvancedSettingsMenuAction implements Action {
     type = ActionTypes.showAdvancedSettingsMenu;
 }
 
+export class ToggleAlwaysEnableAdvancedModeAction implements Action {
+    type = ActionTypes.toggleAlwaysEnableAdvancedMode;
+
+    constructor(public payload: boolean) {}
+}
+
 export class ZephyrLogAction implements Action {
     type = ActionTypes.zephyrLog;
 
@@ -124,6 +131,7 @@ export type Actions =
     | ToggleRightHalfZephyrLoggingAction
     | ToggleZephyrLoggingAction
     | ShowAdvancedSettingsMenuAction
+    | ToggleAlwaysEnableAdvancedModeAction
     | StartLeftHalfPairingAction
     | LeftHalfPairingSuccessAction
     | LeftHalfPairingFailedAction

packages/uhk-web/src/app/store/effects/app.ts

@@ -29,6 +29,7 @@ import {
     UndoLastAction
 } from '../actions/app';
 import { ActionTypes as UpdateActionTypes } from '../actions/auto-update-settings';
+import { ActionTypes as AdvanceSettingsActionTypes } from '../actions/advance-settings.action';
 import { AppRendererService } from '../../services/app-renderer.service';
 import { AppUpdateRendererService } from '../../services/app-update-renderer.service';
 import { ActionTypes as DeviceActionTypes, StartConnectionPollerAction } from '../actions/device';
@@ -145,6 +146,7 @@ export class ApplicationEffects {
                 ActionTypes.SetAppTheme,
                 ActionTypes.ToggleAnimationEnabled,
                 ActionTypes.ToggleKeyboardHalvesAlwaysJoined,
+                AdvanceSettingsActionTypes.toggleAlwaysEnableAdvancedMode,
                 UpdateActionTypes.ToggleCheckForUpdateOnStartup,
                 DeviceActionTypes.SaveConfiguration,
                 SmartMacroDocActionTypes.PanelSizeChanged,

packages/uhk-web/src/app/store/index.ts

@@ -116,6 +116,7 @@ export const metaReducers: MetaReducer<AppState>[] = environment.production
 
 export const advanceSettingsState = (state: AppState) => state.advanceSettings;
 export const getIsAdvancedSettingsMenuVisible = createSelector(advanceSettingsState, fromAdvancedSettings.isAdvancedSettingsMenuVisible);
+export const getAlwaysEnableAdvancedMode = createSelector(advanceSettingsState, fromAdvancedSettings.isAlwaysEnableAdvancedMode);
 export const isLeftHalfPairing = createSelector(advanceSettingsState, fromAdvancedSettings.isLeftHalfPairing);
 export const getIsI2cDebuggingEnabled = createSelector(advanceSettingsState, fromAdvancedSettings.isI2cDebuggingEnabled);
 export const isI2cDebuggingRingBellEnabled = createSelector(advanceSettingsState, fromAdvancedSettings.isI2cDebuggingRingBellEnabled);
@@ -829,11 +830,13 @@ export const getApplicationSettings = createSelector(
     getSmartMacroPanelWidth,
     backlightingColorPalette,
     keyboardHalvesAlwaysJoined,
+    getAlwaysEnableAdvancedMode,
     (updateSettingsState,
         app,
         smartMacroPanelWidth,
         backlightingColorPalette,
         keyboardHalvesAlwaysJoined,
+        alwaysEnableAdvancedMode,
     ): ApplicationSettings => {
         return {
             errorPanelHeight: app.errorPanelHeight,
@@ -843,6 +846,7 @@ export const getApplicationSettings = createSelector(
             appTheme: app.appTheme,
             backlightingColorPalette,
             keyboardHalvesAlwaysJoined,
+            alwaysEnableAdvancedMode,
             smartMacroPanelWidth
         };
     });

packages/uhk-web/src/app/store/reducers/advanced-settings.reducer.ts

@@ -9,6 +9,7 @@ import {
     IsDongleZephyrLoggingEnabledReplyAction,
     IsLeftHalfZephyrLoggingEnabledReplyAction,
     IsRightHalfZephyrLoggingEnabledReplyAction,
+    ToggleAlwaysEnableAdvancedModeAction,
     ZephyrLogAction,
 } from '../actions/advance-settings.action';
 import * as App from '../actions/app';
@@ -23,6 +24,7 @@ export enum ActiveButton {
 
 export interface State {
     activeButton: ActiveButton;
+    alwaysEnableAdvancedMode: boolean;
     i2cDebuggingRingBellEnabled: boolean,
     i2cLogs: Array<XtermLog>;
     isLeftHalfPairing: boolean;
@@ -36,6 +38,7 @@ export interface State {
 
 export const initialState = (): State => ({
     activeButton: ActiveButton.None,
+    alwaysEnableAdvancedMode: false,
     i2cDebuggingRingBellEnabled: false,
     i2cLogs: [],
     isDongleZephyrLoggingEnabled: false,
@@ -49,6 +52,17 @@ export const initialState = (): State => ({
 export function reducer(state = initialState(), action: Actions | App.Actions | Device.Actions) {
     switch (action.type) {
 
+        case App.ActionTypes.LoadApplicationSettingsSuccess: {
+            const settings = (action as App.LoadApplicationSettingsSuccessAction).payload;
+            const alwaysEnableAdvancedMode = !!settings.alwaysEnableAdvancedMode;
+
+            return {
+                ...state,
+                alwaysEnableAdvancedMode,
+                menuVisible: alwaysEnableAdvancedMode || state.menuVisible,
+            };
+        }
+
         case App.ActionTypes.ElectronMainLogReceived: {
             if (!state.isLeftHalfPairing) {
                 return state;
@@ -212,7 +226,17 @@ export function reducer(state = initialState(), action: Actions | App.Actions |
         case ActionTypes.showAdvancedSettingsMenu: {
             return {
                 ...state,
-                menuVisible: true
+                menuVisible: true,
+            };
+        }
+
+        case ActionTypes.toggleAlwaysEnableAdvancedMode: {
+            const alwaysEnableAdvancedMode = (action as ToggleAlwaysEnableAdvancedModeAction).payload;
+
+            return {
+                ...state,
+                alwaysEnableAdvancedMode,
+                menuVisible: alwaysEnableAdvancedMode || state.menuVisible,
             };
         }
 
@@ -240,6 +264,7 @@ export function reducer(state = initialState(), action: Actions | App.Actions |
 }
 
 export const isAdvancedSettingsMenuVisible = (state: State): boolean => state.menuVisible;
+export const isAlwaysEnableAdvancedMode = (state: State): boolean => state.alwaysEnableAdvancedMode;
 export const isLeftHalfPairing = (state: State): boolean => state.isLeftHalfPairing;
 export const isI2cDebuggingEnabled = (state: State): boolean => state.activeButton === ActiveButton.I2CRecoveryDebugging;
 export const isI2cDebuggingRingBellEnabled = (state: State): boolean => state.i2cDebuggingRingBellEnabled;