Add diagnostics info.

Author: kareltucek

right/src/debug.h

@@ -40,15 +40,23 @@ typedef struct {
     uint32_t applied;
     uint32_t action;
     uint32_t delivered;
+    uint8_t scanActive;  // target state (1=press, 0=release) of the last scan change
 } key_life_times_t;
 
 extern key_life_times_t KeyLifeTimes;
 
 #define DEBUG_KEY_LIFE_ENABLED true
 #if DEBUG_KEY_LIFE_ENABLED
 #define DEBUG_KEY_LIFE(STAGE) (KeyLifeTimes.STAGE = Timer_GetCurrentTime())
+// Like DEBUG_KEY_LIFE(scan), but also records whether the change was into an
+// active (pressed) or inactive (released) state.
+#define DEBUG_KEY_LIFE_SCAN(ACTIVE) do { \
+    KeyLifeTimes.scan = Timer_GetCurrentTime(); \
+    KeyLifeTimes.scanActive = (ACTIVE) ? 1 : 0; \
+} while (0)
 #else
 #define DEBUG_KEY_LIFE(STAGE)
+#define DEBUG_KEY_LIFE_SCAN(ACTIVE)
 #endif
 
 // Last-seen state of blockedByReportThrottle(); printed by Hid_DumpTransportState.

right/src/hid/transport.cpp

@@ -70,9 +70,11 @@ extern "C" void Hid_DumpTransportState(void)
     c2usb_log("  powerMode=%d usbUp=%d usbAwake=%d\n",
         (int)CurrentPowerMode, (int)UsbState_IsTransportUp(), (int)UsbState_IsAwake());
     uint32_t now = Timer_GetCurrentTime();
-    c2usb_log("  key life (ms ago): scan=%u queued=%u/forceQueued=%u/applied=%u action=%u delivered=%u\n",
-        now - KeyLifeTimes.scan, now - KeyLifeTimes.queued, now - KeyLifeTimes.forceQueued,
-        now - KeyLifeTimes.applied, now - KeyLifeTimes.action, now - KeyLifeTimes.delivered);
+    c2usb_log("  key life (ms ago): scan(%d)=%u queued=%u/forceQueued=%u/applied=%u action=%u delivered=%u\n",
+        (int)KeyLifeTimes.scanActive, now - KeyLifeTimes.scan, now - KeyLifeTimes.queued,
+        now - KeyLifeTimes.forceQueued, now - KeyLifeTimes.applied, now - KeyLifeTimes.action,
+        now - KeyLifeTimes.delivered);
+    c2usb_log("  inactive kb report: %s\n", Utils_GetUsbReportString(GetInactiveKeyboardReport()));
     c2usb_log("  semaphore (inFlight/retries/needsResend): kb=%d/%d/%d ctl=%d/%d/%d mouse=%d/%d/%d givenUp=%d\n",
         (int)UsbSemaphore.keyboard.inFlight, (int)UsbSemaphore.keyboard.retries, (int)UsbSemaphore.keyboard.needsResending,
         (int)UsbSemaphore.controls.inFlight, (int)UsbSemaphore.controls.retries, (int)UsbSemaphore.controls.needsResending,

right/src/main.c

@@ -116,7 +116,7 @@ void CopyRightKeystateMatrix(void)
         }
 
         if (KeyStates[SlotId_RightKeyboardHalf][targetKeyId].hardwareSwitchState != RightKeyMatrix.keyStates[keyId]) {
-            DEBUG_KEY_LIFE(scan);
+            DEBUG_KEY_LIFE_SCAN(RightKeyMatrix.keyStates[keyId]);
             KeyStates[SlotId_RightKeyboardHalf][targetKeyId].hardwareSwitchState = RightKeyMatrix.keyStates[keyId];
             stateChanged = true;
         }