Fix macro scheduler lockup.#1579
Merged
Merged
Conversation
This would happen when macro end aligns with the macro quota running out.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a macro scheduler edge case where the macro engine could stop being scheduled when a macro finishes exactly as the scheduler’s execution quota is exhausted, leading to a lockup (repro described in the PR).
Changes:
- Keep
EventVector_MacroEngineasserted whenSchedulerPostponingis true, even if no macros are currently awake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would happen when macro end aligns with the macro quota running out.
This is reproducible with this config by flashing
UserConfiguration_macro_deadlock.json onto an uhk 80 and then repeatedly tapping backspace. The keyboard freezes in the Init keymap.
Changelog: