Version bump 1.8.6 & command flags

Author: Ultrawipf

Configurator

@@ -123,27 +123,6 @@ class ClassChooser {
 		return false;
 	}
 
-	/**
-	 * Returns a string of classes available to this classchooser
-	 * ignoredCreatableId will list as creatable even if it is not. Useful to make a single class list as valid if it was already chosen
-	 */ // TODO REMOVE
-	std::string printAvailableClasses(int16_t ignoredCreatableId = 255){
-		std::string ret;
-		for(class_entry<T> cls : class_registry){
-			if(cls.info.visibility == ClassVisibility::hidden || (cls.info.visibility == ClassVisibility::debug && !SystemCommands::allowDebugCommands)){
-				if(ignoredCreatableId != cls.selectionId)
-					continue;
-			}
-
-			ret+= std::to_string(cls.selectionId);
-			ret+= ":";
-			ret+= (cls.isCreatable() || ignoredCreatableId == cls.selectionId) ? "1" : "0";
-			ret+= ":";
-			ret+= cls.info.name;
-			ret+='\n';
-		}
-		return ret;
-	}
 
 	/**
 	 * Generates replies for the command system listing selectable classes

Firmware/FFBoard/Inc/ClassChooser.h

@@ -238,7 +238,13 @@ class CommandHandler {
 
 	std::vector<CmdHandlerCommanddef> registeredCommands;
 
-	// Helper to be used with class enums
+	/**
+	 * Registers a command for this command handler
+	 * @param[in]	cmd		string name of command for serial interface
+	 * @param[in]	cmdid	id enum for command for HID
+	 * @param[in]	help	help message displayed on serial interface
+	 * @param[in]	flags	what access methods are available for a command (see CMDFLAG definitions)
+	 */
 	template<typename ID>
 	void registerCommand(const char* cmd,const ID cmdid,const char* help=nullptr,uint32_t flags = 0){
 		for(CmdHandlerCommanddef& cmdDef : registeredCommands){

Firmware/FFBoard/Inc/CommandHandler.h

@@ -11,7 +11,7 @@
 
 
 
-static const uint8_t SW_VERSION_INT[3] = {1,8,5}; // Version as array. 8 bit each!
+static const uint8_t SW_VERSION_INT[3] = {1,8,6}; // Version as array. 8 bit each!
 
 #define MAX_AXIS 2 // ONLY USE 2 for now else screws HID Reports
 

Firmware/FFBoard/Inc/constants.h

@@ -29,7 +29,7 @@ EncoderLocal::EncoderLocal() : CommandHandler("localenc",CLSID_ENCODER_LOCAL) {
 
 void EncoderLocal::registerCommands(){
 	CommandHandler::registerCommands();
-	registerCommand("cpr", EncoderLocal_commands::cpr, "CPR of encoder");
+	registerCommand("cpr", EncoderLocal_commands::cpr, "CPR of encoder",CMDFLAG_GET|CMDFLAG_SET);
 }
 
 EncoderLocal::~EncoderLocal() {

Firmware/FFBoard/UserExtensions/Src/EncoderLocal.cpp

@@ -64,8 +64,8 @@ MidiMain::MidiMain(){
 
 
 	//CommandHandler::registerCommands();
-	registerCommand("power", MidiMain_commands::power, "Intensity");
-	registerCommand("range", MidiMain_commands::range, "Range of phase change");
+	registerCommand("power", MidiMain_commands::power, "Intensity",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("range", MidiMain_commands::range, "Range of phase change",CMDFLAG_GET|CMDFLAG_SET);
 
 	HAL_TIM_Base_Start_IT(this->timer_update);
 }

Firmware/FFBoard/UserExtensions/Src/MidiMain.cpp

@@ -32,17 +32,17 @@ ShifterAnalog::~ShifterAnalog() {
 void ShifterAnalog::registerCommands(){
 	CommandHandler::registerCommands();
 
-	registerCommand("mode", ShifterAnalog_commands::mode, "Shifter mode");
-	registerCommand("x12", ShifterAnalog_commands::x12, "X-threshold for 1,2 gears");
-	registerCommand("x56", ShifterAnalog_commands::x56, "X-threshold for 5,6 gears");
-	registerCommand("y135", ShifterAnalog_commands::y135, "Y-threshold for 1,3,5 gears");
-	registerCommand("y246", ShifterAnalog_commands::y246, "Y-threshold for 2,4,6 gears");
-	registerCommand("revbtn", ShifterAnalog_commands::revbtn, "Pin for R signal");
-	registerCommand("cspin", ShifterAnalog_commands::cspin, "CS pin for SPI modes");
-	registerCommand("xchan", ShifterAnalog_commands::xchan, "X signal analog pin");
-	registerCommand("ychan", ShifterAnalog_commands::ychan, "Y signal analog pin");
-	registerCommand("vals", ShifterAnalog_commands::vals, "Analog values");
-	registerCommand("gear", ShifterAnalog_commands::gear, "Decoded gear");
+	registerCommand("mode", ShifterAnalog_commands::mode, "Shifter mode",CMDFLAG_GET|CMDFLAG_SET|CMDFLAG_INFOSTRING);
+	registerCommand("x12", ShifterAnalog_commands::x12, "X-threshold for 1,2 gears",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("x56", ShifterAnalog_commands::x56, "X-threshold for 5,6 gears",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("y135", ShifterAnalog_commands::y135, "Y-threshold for 1,3,5 gears",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("y246", ShifterAnalog_commands::y246, "Y-threshold for 2,4,6 gears",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("revbtn", ShifterAnalog_commands::revbtn, "Pin for R signal",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("cspin", ShifterAnalog_commands::cspin, "CS pin for SPI modes",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("xchan", ShifterAnalog_commands::xchan, "X signal analog pin",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("ychan", ShifterAnalog_commands::ychan, "Y signal analog pin",CMDFLAG_GET|CMDFLAG_SET);
+	registerCommand("vals", ShifterAnalog_commands::vals, "Analog values",CMDFLAG_GET);
+	registerCommand("gear", ShifterAnalog_commands::gear, "Decoded gear",CMDFLAG_GET);
 }
 
 void ShifterAnalog::updateAdc(){