Add optional keep screen on functionality#35
Merged
UmerCodez merged 5 commits intoUmerCodez:mainfrom Nov 20, 2025
Merged
Conversation
Owner
|
I’m currently down with dengue fever, so I’m unable to test this at the moment. I’ll run the tests and follow up once I’m feeling better. Thanks |
Contributor
Author
|
No problem, this can wait. Get some rest, hope you feel better soon! |
Owner
|
I am testing it |
The `enableKeepScreenOn` call has been moved into a `LaunchedEffect`. This ensures that the screen is kept on only once when the composable enters the composition, rather than on every recomposition.
The `window` parameter has been removed from the `ControlPadPlayScreen` composable. The window is now obtained directly from the `LocalActivity` composition local.
The `FLAG_KEEP_SCREEN_ON` is now set when entering the `ControlPadPlayScreen` and cleared upon exit. This removes the need to pass the `window` object down through the `NavScreen` and `ControlPadsScreen`, simplifying the composable signatures.
…revent memory leak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't keep the screen on on any screen other than ControlPadPlayScreen.
Releases the screen on flag once exited.
Setting is in the preferences with others as shown:
