Fix Python warning issues in ctfr parser and banner string handling#42
Open
AndreaF17 wants to merge 1 commit into
Open
Fix Python warning issues in ctfr parser and banner string handling#42AndreaF17 wants to merge 1 commit into
AndreaF17 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate Python warning-producing escape sequences in ctfr.py while keeping runtime behavior the same.
Changes:
- Converted the banner ASCII art to a raw triple-quoted string to avoid invalid escape sequence warnings.
- Updated the
clear_url()cleanup regex to use a raw string literal. - Updated
re.sub()usage to passcountas a keyword argument (count=1).
Comments suppressed due to low confidence (1)
ctfr.py:32
- Switching the banner to a raw string changes how existing escape sequences are interpreted. In particular, the
\\at the end of the ASCII art line is no longer an escape and will print as two backslashes instead of one, so behavior/output is not strictly unchanged. If you want to preserve the prior banner output, reduce double-escaped backslashes inside the raw string (or keep a normal string and explicitly escape only what’s needed).
b = r'''
____ _____ _____ ____
/ ___|_ _| ___| _ \
| | | | | |_ | |_) |
| |___ | | | _| | _ <
\____| |_| |_| |_| \_\\
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes warning-producing string escapes in the main script and keeps behavior unchanged.
Changes