Skip to content

Fix Python warning issues in ctfr parser and banner string handling#42

Open
AndreaF17 wants to merge 1 commit into
UnaPibaGeek:masterfrom
AndreaF17:master
Open

Fix Python warning issues in ctfr parser and banner string handling#42
AndreaF17 wants to merge 1 commit into
UnaPibaGeek:masterfrom
AndreaF17:master

Conversation

@AndreaF17
Copy link
Copy Markdown

Summary

This PR removes warning-producing string escapes in the main script and keeps behavior unchanged.

Changes

  • Updated banner ASCII art string in ctfr.py:27 to use a raw triple-quoted string, preventing invalid escape sequence warnings.
  • Updated domain cleanup regex in ctfr.py:40 to use a raw regex literal.
  • Updated re.sub usage in ctfr.py:40 to pass count as a keyword argument (count=1), avoiding deprecation warnings in newer Python versions.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to eliminate Python warning-producing escape sequences in ctfr.py while keeping runtime behavior the same.

Changes:

  • Converted the banner ASCII art to a raw triple-quoted string to avoid invalid escape sequence warnings.
  • Updated the clear_url() cleanup regex to use a raw string literal.
  • Updated re.sub() usage to pass count as a keyword argument (count=1).
Comments suppressed due to low confidence (1)

ctfr.py:32

  • Switching the banner to a raw string changes how existing escape sequences are interpreted. In particular, the \\ at the end of the ASCII art line is no longer an escape and will print as two backslashes instead of one, so behavior/output is not strictly unchanged. If you want to preserve the prior banner output, reduce double-escaped backslashes inside the raw string (or keep a normal string and explicitly escape only what’s needed).
	b = r'''
          ____ _____ _____ ____  
         / ___|_   _|  ___|  _ \ 
        | |     | | | |_  | |_) |
        | |___  | | |  _| |  _ < 
         \____| |_| |_|   |_| \_\\

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants