Skip to content

Commit 1ff59a5

Browse files
authored
Fix MusicKit.configure() return type to Promise<MusicKitInstance> (DefinitelyTyped#74310)
1 parent 511b824 commit 1ff59a5

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

types/musickit-js/MusicKit.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ declare namespace MusicKit {
7979
/**
8080
* Configure a MusicKit instance.
8181
*/
82-
function configure(configuration: Configuration): MusicKitInstance;
82+
function configure(configuration: Configuration): Promise<MusicKitInstance>;
8383
/**
8484
* Returns the configured MusicKit instance.
8585
*/

types/musickit-js/test/musickit-js-tests.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1-
MusicKit.configure({
2-
app: {
3-
build: "1.0",
4-
name: "PLAYER_NAME",
5-
},
6-
developerToken: "devToken",
7-
});
1+
async function testConfigure() {
2+
// $ExpectType MusicKitInstance
3+
const instance = await MusicKit.configure({
4+
app: {
5+
build: "1.0",
6+
name: "PLAYER_NAME",
7+
},
8+
developerToken: "devToken",
9+
});
10+
}
811

912
const player = MusicKit.getInstance();
1013

0 commit comments

Comments
 (0)