Skip to content

Commit 2691c41

Browse files
authored
🤖 Merge PR DefinitelyTyped#74373 [aws-synthetics-puppeteer] Align method return type to AWS documentation and actual usage by @hajin-song
1 parent e95f656 commit 2691c41

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

‎types/aws-synthetics-puppeteer/aws-synthetics-puppeteer-tests.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as synthetics from "Synthetics";
22

33
export const handler = async () => {
4-
const page = synthetics.getPage();
4+
const page = await synthetics.getPage();
55
await page.goto("https://example.com");
66
await page.waitForFrame("https://example.com");
77
await page.screenshot({ path: "/tmp/example.png" });

‎types/aws-synthetics-puppeteer/package.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
{
22
"private": true,
33
"name": "@types/aws-synthetics-puppeteer",
4-
"version": "10.0.9999",
4+
"version": "11.0.9999",
55
"nonNpm": true,
66
"nonNpmDescription": "aws-synthetics-puppeteer",
77
"projects": [
88
"https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries.html"
99
],
1010
"dependencies": {
1111
"@types/node": "*",
12-
"puppeteer-core": "24.2.0",
13-
"aws-xray-sdk-core": "3.10.3"
12+
"puppeteer-core": "24.25.0",
13+
"aws-xray-sdk-core": "3.5.0"
1414
},
1515
"devDependencies": {
1616
"@types/aws-synthetics-puppeteer": "workspace:."

‎types/aws-synthetics-puppeteer/src/Synthetics.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ declare module "Synthetics" {
7676
getCanaryArn(): string;
7777
getCanaryUserAgentString(): string;
7878
getRuntimeVersion(): string;
79-
getPage(): localPuppeteer.Page;
79+
getPage(): Promise<localPuppeteer.Page>;
8080
getUrl(): string;
8181
/**
8282
* Returns global syntheticsConfiguration instance.

0 commit comments

Comments
 (0)