🤖 Merge PR DefinitelyTyped#74793 [mssql] Use enum for MSSQLError error codes by @erehulka

Author: erehulka

types/mssql/index.d.ts

@@ -216,9 +216,32 @@ export interface config {
     beforeConnect?: ((conn: Connection) => void) | undefined;
 }
 
+export declare enum MSSQL_ERROR_CODE {
+    ELOGIN = "ELOGIN",
+    ETIMEOUT = "ETIMEOUT",
+    EDRIVER = "EDRIVER",
+    EALREADYCONNECTED = "EALREADYCONNECTED",
+    EALREADYCONNECTING = "EALREADYCONNECTING",
+    ENOTOPEN = "ENOTOPEN",
+    EINSTLOOKUP = "EINSTLOOKUP",
+    ESOCKET = "ESOCKET",
+    ECONNCLOSED = "ECONNCLOSED",
+    ENOTBEGUN = "ENOTBEGUN",
+    EALREADYBEGUN = "EALREADYBEGUN",
+    EREQINPROG = "EREQINPROG",
+    EABORT = "EABORT",
+    EREQUEST = "EREQUEST",
+    ECANCEL = "ECANCEL",
+    EARGS = "EARGS",
+    EINJECT = "EINJECT",
+    ENOCONN = "ENOCONN",
+    EALREADYPREPARED = "EALREADYPREPARED",
+    ENOTPREPARED = "ENOTPREPARED",
+}
+
 export declare class MSSQLError extends Error {
-    constructor(message: Error | string, code?: string);
-    public code: string;
+    constructor(message: Error | string, code?: MSSQL_ERROR_CODE);
+    public code: MSSQL_ERROR_CODE;
     public name: string;
     public originalError?: Error | undefined;
 }

types/mssql/mssql-tests.ts

@@ -320,11 +320,11 @@ function test_mssql_errors() {
     // Test constructors
     const sqlDriverError = new Error("mock error");
     const mssqlStringError = new sql.MSSQLError("Something went wrong");
-    const baseMSSQLError = new sql.MSSQLError(sqlDriverError, "EREQUEST");
-    const connectionError = new sql.ConnectionError(sqlDriverError, "ELOGIN");
-    const requestError = new sql.RequestError(sqlDriverError, "EREQUEST");
-    const preparedStatementError = new sql.PreparedStatementError(sqlDriverError, "EINJECT");
-    const transactionError = new sql.TransactionError(sqlDriverError, "EABORT");
+    const baseMSSQLError = new sql.MSSQLError(sqlDriverError, sql.MSSQL_ERROR_CODE.EREQUEST);
+    const connectionError = new sql.ConnectionError(sqlDriverError, sql.MSSQL_ERROR_CODE.ELOGIN);
+    const requestError = new sql.RequestError(sqlDriverError, sql.MSSQL_ERROR_CODE.EREQUEST);
+    const preparedStatementError = new sql.PreparedStatementError(sqlDriverError, sql.MSSQL_ERROR_CODE.EINJECT);
+    const transactionError = new sql.TransactionError(sqlDriverError, sql.MSSQL_ERROR_CODE.EABORT);
 
     // Test inheritance
     if (