Skip to content

Commit 5eb97a8

Browse files
authored
🤖 Merge PR DefinitelyTyped#74782 [qr-image] extend encodable data type to match implementation by @KonkenBonken
1 parent 3f6de05 commit 5eb97a8

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

‎types/qr-image/index.d.ts‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ export type ec_level = "L" | "M" | "Q" | "H";
88
/** @default 'png' */
99
export type image_type = "png" | "svg" | "pdf" | "eps";
1010

11+
export type encodable = string | number | Buffer | ReadonlyArray<number>;
12+
1113
export interface Bitmap {
1214
/**
1315
* width (and height) of resulting image in pixels
@@ -55,13 +57,13 @@ export interface Options {
5557
customize?: ((bitmap: Bitmap) => void) | undefined;
5658
}
5759

58-
export function image(text: string, level?: ec_level): NodeJS.ReadableStream;
59-
export function image(text: string, options?: Options): NodeJS.ReadableStream;
60+
export function image(data: encodable, level?: ec_level): NodeJS.ReadableStream;
61+
export function image(data: encodable, options?: Options): NodeJS.ReadableStream;
6062

61-
export function imageSync(text: string, level?: ec_level): Buffer;
62-
export function imageSync(text: string, options?: Options): string | Buffer;
63+
export function imageSync(data: encodable, level?: ec_level): Buffer;
64+
export function imageSync(data: encodable, options?: Options): string | Buffer;
6365

64-
export function svgObject(text: string, level?: ec_level): SvgObject;
65-
export function svgObject(text: string, options?: Options): SvgObject;
66+
export function svgObject(data: encodable, level?: ec_level): SvgObject;
67+
export function svgObject(data: encodable, options?: Options): SvgObject;
6668

67-
export function matrix(text: string, level?: ec_level): (0 | 1)[][];
69+
export function matrix(data: encodable, level?: ec_level): any[][];

‎types/qr-image/qr-image-tests.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ const qr_svg = qr.image("I love QR!", { type: "svg" });
55
qr_svg.pipe(fs.createWriteStream("i_love_qr.svg"));
66

77
const svg_string = qr.imageSync("I love QR!", { type: "svg" });
8+
const svg_string_from_num = qr.imageSync(1234, { type: "svg" });
9+
const svg_string_from_arr = qr.imageSync([1, 128], { type: "svg" });
810

911
// customize
1012
function coord2offset(x: number, y: number, size: number) {

0 commit comments

Comments
 (0)