Skip to content

Commit 63ddf34

Browse files
🤖 Merge PR DefinitelyTyped#74691 [@types/mithril]: mark extra parameter as optional in censor() function by @kshitijanurag
1 parent d377e9e commit 63ddf34

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

‎types/mithril/index.d.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ declare function mount(element: Element, component: null): void; // tslint:disab
99
/** Returns a shallow-cloned object with lifecycle attributes and any given custom attributes omitted. */
1010
declare function censor<
1111
O extends Record<string, any>,
12-
E extends readonly string[],
13-
>(object: O, extra: E): Omit<Mithril._NoLifecycle<O>, E[number]>;
12+
E extends readonly string[] = readonly [],
13+
>(object: O, extra?: E): Omit<Mithril._NoLifecycle<O>, E[number]>;
1414

1515
/** Makes an XHR request and returns a promise. */
1616
declare function request<T>(options: Mithril.RequestOptions<T> & { url: string }): Promise<T>;

‎types/mithril/test/test-misc.ts‎

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,22 @@ const params = parseQueryString("?id=123");
99

1010
const qstr = buildQueryString({ id: 123 });
1111

12-
const censored = censor({ one: "two", enabled: false, oninit: () => {} }, ["enabled"] as const);
13-
// @ts-expect-error
14-
censored.enabled;
15-
// @ts-expect-error
16-
censored.oninit;
17-
censored.one;
12+
{
13+
const censored = censor({ one: "two", enabled: false, oninit: () => {} }, ["enabled"] as const);
14+
// @ts-expect-error
15+
censored.enabled;
16+
// @ts-expect-error
17+
censored.oninit;
18+
censored.one;
19+
}
20+
21+
{
22+
const censored = censor({ one: "two", enabled: false, oninit: () => {} });
23+
censored.enabled;
24+
// @ts-expect-error
25+
censored.oninit;
26+
censored.one;
27+
}
1828

1929
render(document.body, "Hello");
2030
render(document.body, h("h1", "Test"));

0 commit comments

Comments
 (0)