🤖 Merge PR DefinitelyTyped#73304 feat(poool-engage): add filters on createElement by @maximedasilva

Author: maximedasilva

types/poool-engage/index.d.ts

@@ -296,7 +296,7 @@ export namespace Poool {
          *
          * More infos: https://www.poool.dev/docs/engage/javascript/methods#createelement
          */
-        createElement(slug: string, target: string | Element): Promise<EngageElement>;
+        createElement(slug: string, target: string | Element, opts?: { filters?: string[] }): Promise<EngageElement>;
 
         /**
          * Creates all elements matching multiple conditions like device, country, custom filters, etc.

types/poool-engage/package.json

@@ -1,7 +1,7 @@
 {
     "private": true,
     "name": "@types/poool-engage",
-    "version": "2.1.9999",
+    "version": "2.2.9999",
     "nonNpm": true,
     "nonNpmDescription": "poool-engage",
     "projects": [

types/poool-engage/poool-engage-tests.ts

@@ -47,6 +47,9 @@ const engage = Engage.init("key-string");
 // $ExpectType Promise<EngageElement>
 engage.createElement("key", "value");
 
+// $ExpectType Promise<EngageElement>
+Engage.createElement("key", "target", { filters: ["filter1", "filter2"] });
+
 // $ExpectType Engage
 engage.config(
     {