Skip to content

Commit 9a48f00

Browse files
authored
🤖 Merge PR DefinitelyTyped#72289 MapBox SDK: extend geocode response to align with documentation by @murbanowicz
1 parent d3bf695 commit 9a48f00

File tree

2 files changed

+33
-8
lines changed

2 files changed

+33
-8
lines changed

‎types/mapbox__mapbox-sdk/index.d.ts‎

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -316,15 +316,13 @@ declare module "@mapbox/mapbox-sdk/services/datasets" {
316316
// eslint-disable-next-line @definitelytyped/no-declare-current-package
317317
declare module "@mapbox/mapbox-sdk/services/directions" {
318318
import * as GeoJSON from "geojson";
319-
import { LngLatLike } from "mapbox-gl";
320319
// eslint-disable-next-line @definitelytyped/no-self-import
321320
import MapiClient, { SdkConfig } from "@mapbox/mapbox-sdk/lib/classes/mapi-client";
322321
// eslint-disable-next-line @definitelytyped/no-self-import
323322
import {
324323
Coordinates,
325324
DirectionsApproach,
326-
MapboxProfile,
327-
MapiRequest,
325+
MapiRequest
328326
} from "@mapbox/mapbox-sdk/lib/classes/mapi-request";
329327

330328
export default function Directions(config: SdkConfig | MapiClient): DirectionsService;
@@ -876,7 +874,7 @@ declare module "@mapbox/mapbox-sdk/services/directions" {
876874
// eslint-disable-next-line @definitelytyped/no-declare-current-package
877875
declare module "@mapbox/mapbox-sdk/services/geocoding-v6" {
878876
// eslint-disable-next-line @definitelytyped/no-self-import
879-
import { Coordinates as MapiRequestCoordinates, MapiRequest } from "@mapbox/mapbox-sdk/lib/classes/mapi-request";
877+
import { MapiRequest, Coordinates as MapiRequestCoordinates } from "@mapbox/mapbox-sdk/lib/classes/mapi-request";
880878
// eslint-disable-next-line @definitelytyped/no-self-import
881879
import MapiClient, { SdkConfig } from "@mapbox/mapbox-sdk/lib/classes/mapi-client";
882880

@@ -1122,6 +1120,31 @@ declare module "@mapbox/mapbox-sdk/services/geocoding-v6" {
11221120
* available and applicable to a given country or area.
11231121
*/
11241122
context: Context;
1123+
/**
1124+
* Feature id. The mapbox_id uniquely identifies a place in the Mapbox search database.
1125+
* Mapbox ID's are accepted in requests to the Geocoding API as a forward search, and will
1126+
* return the feature corresponding to that id.
1127+
*/
1128+
mapbox_id: string;
1129+
/**
1130+
* Formatted string of address_number and street.
1131+
*/
1132+
name: string;
1133+
/**
1134+
* The canonical or otherwise more common alias for the feature name. For example,
1135+
* searching for "America" will return "America" as the name, and "United States" as
1136+
* name_preferred.
1137+
*/
1138+
name_preferred?: string;
1139+
/**
1140+
* Formatted string of result context: place region country postcode. The part of the result
1141+
* which comes after name.
1142+
*/
1143+
place_formatted?: string;
1144+
/**
1145+
* Full formatted string of the feature, combining name_preferred and place_formatted.
1146+
*/
1147+
full_address?: string;
11251148
}
11261149

11271150
interface Coordinates {
@@ -1742,7 +1765,7 @@ declare module "@mapbox/mapbox-sdk/services/optimization" {
17421765
// eslint-disable-next-line @definitelytyped/no-self-import
17431766
import { Waypoint } from "@mapbox/mapbox-sdk/services/directions";
17441767
// eslint-disable-next-line @definitelytyped/no-self-import
1745-
import { DirectionsApproach, MapboxProfile, MapiRequest } from "@mapbox/mapbox-sdk/lib/classes/mapi-request";
1768+
import { MapboxProfile, MapiRequest } from "@mapbox/mapbox-sdk/lib/classes/mapi-request";
17461769
// eslint-disable-next-line @definitelytyped/no-self-import
17471770
import MapiClient, { SdkConfig } from "@mapbox/mapbox-sdk/lib/classes/mapi-client";
17481771

@@ -2088,8 +2111,7 @@ declare module "@mapbox/mapbox-sdk/services/styles" {
20882111

20892112
// eslint-disable-next-line @definitelytyped/no-declare-current-package
20902113
declare module "@mapbox/mapbox-sdk/services/tilequery" {
2091-
import * as mapboxgl from "mapbox-gl";
2092-
// eslint-disable-next-line @definitelytyped/no-self-import
2114+
// eslint-disable-next-line @definitelytyped/no-self-import
20932115
import { Coordinates, MapiRequest } from "@mapbox/mapbox-sdk/lib/classes/mapi-request";
20942116
// eslint-disable-next-line @definitelytyped/no-self-import
20952117
import MapiClient, { SdkConfig } from "@mapbox/mapbox-sdk/lib/classes/mapi-client";

‎types/mapbox__mapbox-sdk/mapbox__mapbox-sdk-tests.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import mbxClient from "@mapbox/mapbox-sdk";
22
import { SdkConfig } from "@mapbox/mapbox-sdk/lib/classes/mapi-client";
33
import { MapiRequest } from "@mapbox/mapbox-sdk/lib/classes/mapi-request";
44
import { MapiResponse } from "@mapbox/mapbox-sdk/lib/classes/mapi-response";
5-
import Directions, { DirectionsResponse, DirectionsService } from "@mapbox/mapbox-sdk/services/directions";
5+
import Directions, { DirectionsService } from "@mapbox/mapbox-sdk/services/directions";
66
import Geocoding, { GeocodeService } from "@mapbox/mapbox-sdk/services/geocoding";
77
import GeocodingV6, { GeocodeService as GeocodeServiceV6 } from "@mapbox/mapbox-sdk/services/geocoding-v6";
88
import Isochrone, { IsochroneService } from "@mapbox/mapbox-sdk/services/isochrone";
@@ -289,6 +289,9 @@ geocodeServiceV6
289289
.then(({ body }) => {
290290
body.features.forEach((feature) => {
291291
const shortCode = feature.properties.context.place?.short_code;
292+
const placeFormatted = feature.properties.place_formatted;
293+
const fullAddress = feature.properties.full_address;
294+
const name_preferred = feature.properties.name_preferred;
292295
});
293296
});
294297

0 commit comments

Comments
 (0)