Skip to content

Commit 9b936f8

Browse files
agachumaUJAM-JHpkellett
authored
🤖 Merge PR DefinitelyTyped#73469 Feature/mapping editor by @agachuma
Co-authored-by: Jan Hörnle <jhoernle@ujam.com> Co-authored-by: Paul Kellett <paul.kellett@mda-vst.com>
1 parent 18d88c3 commit 9b936f8

3 files changed

Lines changed: 13 additions & 4 deletions

File tree

types/gorilla-engine/components/MappingEditor.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
declare namespace GorillaEngine.UI {
2+
23
interface Zone {
34
path: string;
45
name: string;
@@ -16,7 +17,7 @@ declare namespace GorillaEngine.UI {
1617
refreshView(index?: number): void;
1718
selectAllZones(): void;
1819
deselectAllZones(): void;
19-
selectZones(zones: Partial<Zone[]>): void;
20+
selectZones(zones: Partial<Zone[]>):void;
2021
addZones(zones: Partial<Zone[]>): void;
2122
removeZones(zones: Partial<Zone[]>): void;
2223
}

types/gorilla-engine/gorilla-engine-tests.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
const mylabel = new GorillaEngine.UI.Label({ text: "rr" });
23

34
const combo = new GorillaEngine.UI.ComboBox({ id: "myCombo", x: 0 });
@@ -12,6 +13,6 @@ const knob = new GorillaEngine.UI.Knob({ id: "myknob" });
1213

1314
const label = new GorillaEngine.UI.Label({ margin: 5 });
1415

15-
const slider = new GorillaEngine.UI.Slider({ id: "slider", x: 0 });
16+
const slider = new GorillaEngine.UI.Slider({ id: "slider", x: 0, y: 2 });
1617

17-
const mappingEditor = new GorillaEngine.UI.MappingEditor({ id: "myNewMappingEditor", x: 3, y: 2 });
18+
const mappingEditor = new GorillaEngine.UI.MappingEditor({ id: 'myNewMappingEditor', x: 3, y:2})

types/gorilla-engine/index.d.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,13 @@ declare namespace GorillaEngine {
174174
* @param module The serialised module to set as a string
175175
*/
176176
setModuleAtPath(path: string, module: string): boolean;
177+
/**
178+
* Method used to replace a module in an instrument in a given path
179+
* @param path The path to the module that should be retrieved.
180+
* @param module The serialised module to replace as a string
181+
*/
182+
replaceModuleAtPath(path: string, module: string): boolean;
183+
177184
/**
178185
* Method used to determine if a value from the Gorilla Engine is a module.
179186
*
@@ -598,4 +605,4 @@ declare namespace GorillaEngine {
598605
*/
599606
function setSettingsButtonPosition(x: number, y: number): void;
600607
}
601-
}
608+
}

0 commit comments

Comments
 (0)