Skip to content

Commit a0ce509

Browse files
hkleungaihkleungai
authored
🤖 Merge PR DefinitelyTyped#74289 fix(node): add overloads for process.send() by @hkleungai 
1 parent bc2d982 commit a0ce509

File tree

8 files changed

+96
-48
lines changed

8 files changed

+96
-48
lines changed

‎types/node/node-tests/process.ts‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,19 @@ import { fileURLToPath } from "node:url";
7777
process.channel.unref();
7878
}
7979
if (process.send) {
80-
let r: boolean = process.send("aMessage");
81-
r = process.send({ msg: "foo" }, new net.Server());
82-
r = process.send({ msg: "foo" }, new net.Socket());
83-
r = process.send({ msg: "foo" }, new dgram.Socket());
84-
r = process.send({ msg: "foo" }, new net.Server(), { keepOpen: true });
85-
r = process.send({ msg: "foo" }, new net.Socket(), { keepOpen: true });
86-
r = process.send({ msg: "foo" }, new dgram.Socket(), { keepOpen: true });
87-
r = process.send({ msg: "foo" }, new net.Server(), { keepOpen: true }, (err: Error | null) => {});
88-
r = process.send({ msg: "foo" }, new net.Socket(), { keepOpen: true }, (err: Error | null) => {});
89-
r = process.send({ msg: "foo" }, new dgram.Socket(), { keepOpen: true }, (err: Error | null) => {});
80+
let r: boolean;
81+
let sendHandle = Math.random() < 0.5
82+
? new net.Server()
83+
: Math.random() < 0.5
84+
? new net.Socket()
85+
: new dgram.Socket();
86+
87+
r = process.send("aMessage");
88+
r = process.send({ msg: "foo" }, sendHandle);
89+
r = process.send({ msg: "foo" }, sendHandle, { keepOpen: true });
90+
r = process.send({ msg: "foo" }, (err: Error | null) => {});
91+
r = process.send({ msg: "foo" }, sendHandle, (err: Error | null) => {});
92+
r = process.send({ msg: "foo" }, sendHandle, { keepOpen: true }, (err: Error | null) => {});
9093
}
9194
if (process.disconnect) {
9295
process.disconnect();

‎types/node/process.d.ts‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1908,8 +1908,17 @@ declare module "node:process" {
19081908
*/
19091909
send?(
19101910
message: any,
1911-
sendHandle?: SendHandle,
1912-
options?: MessageOptions,
1911+
callback?: (error: Error | null) => void,
1912+
): boolean;
1913+
send?(
1914+
message: any,
1915+
sendHandle: SendHandle,
1916+
callback?: (error: Error | null) => void,
1917+
): boolean;
1918+
send?(
1919+
message: any,
1920+
sendHandle: SendHandle,
1921+
options: MessageOptions,
19131922
callback?: (error: Error | null) => void,
19141923
): boolean;
19151924
/**

‎types/node/v20/process.d.ts‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1714,8 +1714,17 @@ declare module "process" {
17141714
*/
17151715
send?(
17161716
message: any,
1717-
sendHandle?: SendHandle,
1718-
options?: MessageOptions,
1717+
callback?: (error: Error | null) => void,
1718+
): boolean;
1719+
send?(
1720+
message: any,
1721+
sendHandle: SendHandle,
1722+
callback?: (error: Error | null) => void,
1723+
): boolean;
1724+
send?(
1725+
message: any,
1726+
sendHandle: SendHandle,
1727+
options: MessageOptions,
17191728
callback?: (error: Error | null) => void,
17201729
): boolean;
17211730
/**

‎types/node/v20/test/process.ts‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,19 @@ import { fileURLToPath } from "node:url";
7878
process.channel.unref();
7979
}
8080
if (process.send) {
81-
let r: boolean = process.send("aMessage");
82-
r = process.send({ msg: "foo" }, new net.Server());
83-
r = process.send({ msg: "foo" }, new net.Socket());
84-
r = process.send({ msg: "foo" }, new dgram.Socket());
85-
r = process.send({ msg: "foo" }, new net.Server(), { keepOpen: true });
86-
r = process.send({ msg: "foo" }, new net.Socket(), { keepOpen: true });
87-
r = process.send({ msg: "foo" }, new dgram.Socket(), { keepOpen: true });
88-
r = process.send({ msg: "foo" }, new net.Server(), { keepOpen: true }, (err: Error | null) => {});
89-
r = process.send({ msg: "foo" }, new net.Socket(), { keepOpen: true }, (err: Error | null) => {});
90-
r = process.send({ msg: "foo" }, new dgram.Socket(), { keepOpen: true }, (err: Error | null) => {});
81+
let r: boolean;
82+
let sendHandle = Math.random() < 0.5
83+
? new net.Server()
84+
: Math.random() < 0.5
85+
? new net.Socket()
86+
: new dgram.Socket();
87+
88+
r = process.send("aMessage");
89+
r = process.send({ msg: "foo" }, sendHandle);
90+
r = process.send({ msg: "foo" }, sendHandle, { keepOpen: true });
91+
r = process.send({ msg: "foo" }, (err: Error | null) => {});
92+
r = process.send({ msg: "foo" }, sendHandle, (err: Error | null) => {});
93+
r = process.send({ msg: "foo" }, sendHandle, { keepOpen: true }, (err: Error | null) => {});
9194
}
9295
}
9396

‎types/node/v22/process.d.ts‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1787,8 +1787,17 @@ declare module "process" {
17871787
*/
17881788
send?(
17891789
message: any,
1790-
sendHandle?: SendHandle,
1791-
options?: MessageOptions,
1790+
callback?: (error: Error | null) => void,
1791+
): boolean;
1792+
send?(
1793+
message: any,
1794+
sendHandle: SendHandle,
1795+
callback?: (error: Error | null) => void,
1796+
): boolean;
1797+
send?(
1798+
message: any,
1799+
sendHandle: SendHandle,
1800+
options: MessageOptions,
17921801
callback?: (error: Error | null) => void,
17931802
): boolean;
17941803
/**

‎types/node/v22/test/process.ts‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,19 @@ import { fileURLToPath } from "node:url";
8080
process.channel.unref();
8181
}
8282
if (process.send) {
83-
let r: boolean = process.send("aMessage");
84-
r = process.send({ msg: "foo" }, new net.Server());
85-
r = process.send({ msg: "foo" }, new net.Socket());
86-
r = process.send({ msg: "foo" }, new dgram.Socket());
87-
r = process.send({ msg: "foo" }, new net.Server(), { keepOpen: true });
88-
r = process.send({ msg: "foo" }, new net.Socket(), { keepOpen: true });
89-
r = process.send({ msg: "foo" }, new dgram.Socket(), { keepOpen: true });
90-
r = process.send({ msg: "foo" }, new net.Server(), { keepOpen: true }, (err: Error | null) => {});
91-
r = process.send({ msg: "foo" }, new net.Socket(), { keepOpen: true }, (err: Error | null) => {});
92-
r = process.send({ msg: "foo" }, new dgram.Socket(), { keepOpen: true }, (err: Error | null) => {});
83+
let r: boolean;
84+
let sendHandle = Math.random() < 0.5
85+
? new net.Server()
86+
: Math.random() < 0.5
87+
? new net.Socket()
88+
: new dgram.Socket();
89+
90+
r = process.send("aMessage");
91+
r = process.send({ msg: "foo" }, sendHandle);
92+
r = process.send({ msg: "foo" }, sendHandle, { keepOpen: true });
93+
r = process.send({ msg: "foo" }, (err: Error | null) => {});
94+
r = process.send({ msg: "foo" }, sendHandle, (err: Error | null) => {});
95+
r = process.send({ msg: "foo" }, sendHandle, { keepOpen: true }, (err: Error | null) => {});
9396
}
9497
}
9598

‎types/node/v24/process.d.ts‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1786,8 +1786,17 @@ declare module "process" {
17861786
*/
17871787
send?(
17881788
message: any,
1789-
sendHandle?: SendHandle,
1790-
options?: MessageOptions,
1789+
callback?: (error: Error | null) => void,
1790+
): boolean;
1791+
send?(
1792+
message: any,
1793+
sendHandle: SendHandle,
1794+
callback?: (error: Error | null) => void,
1795+
): boolean;
1796+
send?(
1797+
message: any,
1798+
sendHandle: SendHandle,
1799+
options: MessageOptions,
17911800
callback?: (error: Error | null) => void,
17921801
): boolean;
17931802
/**

‎types/node/v24/test/process.ts‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,19 @@ import { fileURLToPath } from "node:url";
8080
process.channel.unref();
8181
}
8282
if (process.send) {
83-
let r: boolean = process.send("aMessage");
84-
r = process.send({ msg: "foo" }, new net.Server());
85-
r = process.send({ msg: "foo" }, new net.Socket());
86-
r = process.send({ msg: "foo" }, new dgram.Socket());
87-
r = process.send({ msg: "foo" }, new net.Server(), { keepOpen: true });
88-
r = process.send({ msg: "foo" }, new net.Socket(), { keepOpen: true });
89-
r = process.send({ msg: "foo" }, new dgram.Socket(), { keepOpen: true });
90-
r = process.send({ msg: "foo" }, new net.Server(), { keepOpen: true }, (err: Error | null) => {});
91-
r = process.send({ msg: "foo" }, new net.Socket(), { keepOpen: true }, (err: Error | null) => {});
92-
r = process.send({ msg: "foo" }, new dgram.Socket(), { keepOpen: true }, (err: Error | null) => {});
83+
let r: boolean;
84+
let sendHandle = Math.random() < 0.5
85+
? new net.Server()
86+
: Math.random() < 0.5
87+
? new net.Socket()
88+
: new dgram.Socket();
89+
90+
r = process.send("aMessage");
91+
r = process.send({ msg: "foo" }, sendHandle);
92+
r = process.send({ msg: "foo" }, sendHandle, { keepOpen: true });
93+
r = process.send({ msg: "foo" }, (err: Error | null) => {});
94+
r = process.send({ msg: "foo" }, sendHandle, (err: Error | null) => {});
95+
r = process.send({ msg: "foo" }, sendHandle, { keepOpen: true }, (err: Error | null) => {});
9396
}
9497
}
9598

0 commit comments

Comments
 (0)