🤖 Merge PR DefinitelyTyped#72985 feat(magicmirror-module): update the return type of NodeHelper.create and start() in Module.register by @hermanho

Author: hermanho

types/magicmirror-module/index.d.ts

@@ -18,7 +18,7 @@ declare namespace Module {
         // Subclassable methods
         init: () => void;
         loaded: (callback?: () => void) => void;
-        start: () => void;
+        start: () => void | Promise<void>;
         getScripts: () => string[];
         getStyles: () => string[];
         getTranslations: () => { [key: string]: string };
@@ -50,7 +50,9 @@ declare namespace Module {
 
 /* tslint:disable:no-single-declare-module */
 declare module "node_helper" {
-    function create(object: ThisType<NonNullable<NodeHelperModule>> & Partial<NodeHelperModule>): void;
+    function create<T>(
+        object: ThisType<T & NonNullable<NodeHelperModule>> & Partial<NodeHelperModule>,
+    ): new() => T & NodeHelperModule;
 
     interface NodeHelperModule {
         readonly name: string;

types/magicmirror-module/magicmirror-module-tests.ts

@@ -91,7 +91,14 @@ Module.register<TestConfig>("test", {
     hidden: false,
 });
 
-NodeHelper.create({
+Module.register<TestConfig>("test2", {
+    async start() {
+        console.log("started");
+        await Promise.resolve();
+    },
+});
+
+const ModuleClass = NodeHelper.create({
     start() {
         Log.debug("Starting module: " + this.name);
         return;
@@ -113,3 +120,8 @@ NodeHelper.create({
         console.log("hi");
     },
 });
+
+const moduleInstance = new ModuleClass();
+moduleInstance.start();
+moduleInstance.start();
+moduleInstance.socketNotificationReceived("abc", { data: "test" });