🤖 Merge PR DefinitelyTyped#74149 [selenium-webdriver] Fix driver.wait() return type for elementsLocated() by @slhck

Author: slhck

types/selenium-webdriver/lib/webdriver.d.ts

@@ -110,6 +110,14 @@ export class Condition<T> {
  * Defines a condition that will result in a {@link WebElement}.
  */
 export class WebElementCondition extends Condition<WebElement> {
+    /**
+     * Private discriminator to prevent structural type compatibility with
+     * Condition<WebElement[]>. This ensures TypeScript correctly resolves
+     * driver.wait() overloads when using elementsLocated() vs elementLocated().
+     * @see https://github.com/SeleniumHQ/selenium/issues/14239
+     */
+    private readonly __isWebElementCondition: true;
+
     /**
      * @param {string} message A descriptive error message. Should complete the
      *     sentence "Waiting [...]"

types/selenium-webdriver/test/index.ts

@@ -599,6 +599,29 @@ function TestUntilModule() {
     conditionWebElements = webdriver.until.elementsLocated(webdriver.By.className("class"));
 }
 
+// Test for https://github.com/SeleniumHQ/selenium/issues/14239
+// driver.wait(until.elementsLocated(...)) should return Promise<WebElement[]>, not WebElementPromise
+async function TestElementsLocatedReturnsArray() {
+    let driver: webdriver.WebDriver = new webdriver.Builder().withCapabilities(webdriver.Capabilities.chrome()).build();
+
+    // elementsLocated should return Condition<WebElement[]>
+    // driver.wait should correctly resolve this to Promise<WebElement[]>
+    const elements: webdriver.WebElement[] = await driver.wait(
+        webdriver.until.elementsLocated(webdriver.By.css(".foo")),
+    );
+
+    // These should compile - elements is an array
+    const length: number = elements.length;
+    elements.forEach((el: webdriver.WebElement) => el.click());
+    const mapped: string[] = elements.map((el: webdriver.WebElement) => "test");
+
+    // elementLocated (singular) should still return WebElementPromise
+    const singleElement: webdriver.WebElement = await driver.wait(
+        webdriver.until.elementLocated(webdriver.By.css(".foo")),
+    );
+    singleElement.click();
+}
+
 function TestShadowRoot() {
     let driver: webdriver.WebDriver = new webdriver.Builder().withCapabilities(webdriver.Capabilities.chrome()).build();